Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2076063002: Clarify that WebContents::GetLastCommittedURL returns the virtual URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/browser/web_contents.h » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 96b14ef6da138ec6f3241f3cab915ac7f10822ed..8a7ad797c3cc9c17166d5300a0f58de503cb8a34 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -38,6 +38,10 @@ class CONTENT_EXPORT NavigationHandle {
// The URL the frame is navigating to. This may change during the navigation
// when encountering a server redirect.
+ // This URL may not be the same as the virtual URL returned from
+ // WebContents::GetVisibleURL and WebContents::GetLastCommittedURL. For
+ // example, viewing a page's source navigates to the URL of the page, but the
+ // virtual URL is prefixed with "view-source".
Charlie Reis 2016/06/20 17:33:06 nit: Add colon to "view-source:"
dominickn 2016/06/20 23:56:06 Done.
virtual const GURL& GetURL() = 0;
// Whether the navigation is taking place in the main frame or in a subframe.
« no previous file with comments | « no previous file | content/public/browser/web_contents.h » ('j') | content/public/browser/web_contents.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698