Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2075953002: Add com.apple.fonts to the sandbox profiles for Sierra (Closed)

Created:
4 years, 6 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek, Greg K
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add com.apple.fonts to the sandbox profiles for Sierra It was done for WebKit in http://wkrev.com/192805 Without it, the renderer process can't talk to the font server on macOS 10.12 Sierra and spawns an entire font server in each renderer process. This CL reduces the memory footprint of each renderer process by ~600MB on macOS 10.12 Beta (16A201w). BUG=619981 Committed: https://crrev.com/56fd33cb2374b335e1c309c2af2940ad469ccee3 Cr-Commit-Position: refs/heads/master@{#402523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/ppapi_plugin/ppapi.sb View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer.sb View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tapted
Hi Robert, please take a look
4 years, 6 months ago (2016-06-17 02:53:22 UTC) #4
Robert Sesek
Ack'ing this CL. But before approving this either Greg or I need to look at ...
4 years, 6 months ago (2016-06-17 20:51:16 UTC) #6
Greg K
On 2016/06/17 20:51:16, Robert Sesek wrote: > Ack'ing this CL. But before approving this either ...
4 years, 5 months ago (2016-06-28 18:16:26 UTC) #7
Robert Sesek
OWNERS stamp LGTM
4 years, 5 months ago (2016-06-28 18:17:33 UTC) #8
Robert Sesek
On 2016/06/28 18:16:26, Greg Kerr wrote: > On 2016/06/17 20:51:16, Robert Sesek wrote: > > ...
4 years, 5 months ago (2016-06-28 18:17:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2075953002/1
4 years, 5 months ago (2016-06-28 18:34:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 20:22:09 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:25:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56fd33cb2374b335e1c309c2af2940ad469ccee3
Cr-Commit-Position: refs/heads/master@{#402523}

Powered by Google App Engine
This is Rietveld 408576698