Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2075893003: Fix a crash in CustomTabsConnectionService w/o FRE. (Closed)

Created:
4 years, 6 months ago by Ted C
Modified:
4 years, 6 months ago
Reviewers:
Ian Wen, Benoit L
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash in CustomTabsConnectionService w/o FRE. Using the custom tabs test app if you bind to the service w/o first going through FRE and then you hit android back, Chrome is crashing in the background (this is on a KK device). Caused by: java.lang.NullPointerException E/AndroidRuntime( 8358): at org.chromium.chrome.browser.customtabs.CustomTabsConnectionService.onUnbind(CustomTabsConnectionService.java:37) BUG= Committed: https://crrev.com/8b69356ad2c80fcde148542b22b407860b224643 Cr-Commit-Position: refs/heads/master@{#400566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Ted C
PTAL
4 years, 6 months ago (2016-06-16 21:28:44 UTC) #2
Benoit L
On 2016/06/16 21:28:44, Ted C wrote: > PTAL Nice find, thanks! LGTM
4 years, 6 months ago (2016-06-17 08:03:34 UTC) #3
Ian Wen
Big thanks for the fix!!! Tommy actually sees this crash a lot on his canary ...
4 years, 6 months ago (2016-06-17 23:04:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075893003/1
4 years, 6 months ago (2016-06-18 00:54:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-18 01:30:28 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 01:31:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b69356ad2c80fcde148542b22b407860b224643
Cr-Commit-Position: refs/heads/master@{#400566}

Powered by Google App Engine
This is Rietveld 408576698