chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java - Issue 2075893003: Fix a crash in CustomTabsConnectionService w/o FRE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

Issue 2075893003: Fix a crash in CustomTabsConnectionService w/o FRE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

index 08509ab4fff95421501d27a50cce2f5d2b620b80..68307c9de7cf1ccd2dd350f78bc45a9a794c2d43 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

@@ -34,7 +34,7 @@ public class CustomTabsConnectionService extends CustomTabsService {

@Override

public boolean onUnbind(Intent intent) {

super.onUnbind(intent);

- mConnection.logCall("Service#onUnbind()", true);

+ if (mConnection != null) mConnection.logCall("Service#onUnbind()", true);

return false; // No support for onRebind().

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »