Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10411)

Unified Diff: chrome/installer/mini_installer/BUILD.gn

Issue 2075863003: Use runtime_deps to tell create_installer_archive what dlls to copy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/BUILD.gn
diff --git a/chrome/installer/mini_installer/BUILD.gn b/chrome/installer/mini_installer/BUILD.gn
index 4eecab413281aa296d2a566541b7a4ac60a6aace..8d5a288c80ea444499a50b9491f1f29368331984 100644
--- a/chrome/installer/mini_installer/BUILD.gn
+++ b/chrome/installer/mini_installer/BUILD.gn
@@ -68,6 +68,18 @@ source_set("unit_tests") {
packed_files_rc_file = "$target_gen_dir/packed_files.rc"
+# The runtime deps are used to tell create_installer_archive what component
+# build DLLs need to be packaged.
gab 2016/06/20 15:15:26 s/component build DLLs need to be packaged/compone
+setup_runtime_deps = "$root_gen_dir/setup.runtime_deps"
+installer_runtime_deps = "$root_gen_dir/mini_installer.runtime_deps"
gab 2016/06/20 15:15:26 s/installer_runtime_deps/component_runtime_deps/
+
+group("setup_runtime_deps") {
+ write_runtime_deps = setup_runtime_deps
+ data_deps = [
+ "//chrome/installer/setup",
+ ]
+}
+
action("archive") {
script = "//chrome/tools/build/win/create_installer_archive.py"
@@ -98,6 +110,10 @@ action("archive") {
rebase_path(packed_files_rc_file, root_build_dir),
"--target_arch=$current_cpu",
"--distribution=_google_chrome",
+ "--runtime_deps",
+ rebase_path(installer_runtime_deps, root_build_dir),
+ "--setup_runtime_deps",
+ rebase_path(setup_runtime_deps, root_build_dir),
# Optional arguments to generate diff installer.
#'--last_chrome_installer=C:/Temp/base',
@@ -109,6 +125,7 @@ action("archive") {
]
deps = [
+ ":setup_runtime_deps",
"//chrome",
"//chrome:main_dll",
"//chrome/browser/extensions/default_extensions",
@@ -151,6 +168,8 @@ action("archive") {
deps += [ "//v8" ]
}
+ write_runtime_deps = installer_runtime_deps
gab 2016/06/20 15:15:26 These actually only need to be the deps for chrome
+
depfile = "$target_gen_dir/archive.d"
args += [
"--depfile",
« no previous file with comments | « no previous file | chrome/tools/build/win/create_installer_archive.py » ('j') | chrome/tools/build/win/create_installer_archive.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698