components/bitmap_uploader/bitmap_uploader.cc - Issue 2075853004: Implement SharedQuadStateList StructTraits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bitmap_uploader/bitmap_uploader.cc

Issue 2075853004: Implement SharedQuadStateList StructTraits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bitmap_uploader/bitmap_uploader.cc

diff --git a/components/bitmap_uploader/bitmap_uploader.cc b/components/bitmap_uploader/bitmap_uploader.cc

index a6c78992a247196abf8ce8a53f87b4c66598f4a0..92556702f117348519ba045e8869299674864cce 100644

--- a/components/bitmap_uploader/bitmap_uploader.cc

+++ b/components/bitmap_uploader/bitmap_uploader.cc

@@ -80,7 +80,9 @@ void BitmapUploader::Upload() {

frame->resources.resize(0u);

pass->quads.resize(0u);

- pass->shared_quad_states.push_back(mojo::CreateDefaultSQS(bounds.size()));

+ cc::SharedQuadState* sqs =

+ pass->shared_quad_states.AllocateAndConstruct<cc::SharedQuadState>();

sky 2016/06/17 23:05:36 Who owns the return value?

Fady Samuel 2016/06/18 01:27:51 Added a comment. It's owned by the shared_quad_sta

+ mojo::CreateDefaultSQS(bounds.size(), sqs);

if (bitmap_.get()) {

gpu::gles2::GLES2Interface* gl = gles2_context_->interface();