Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2075793003: V8: Compare infra- and client-side gyp flags. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, jochen (gone - plz use gerrit)
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Compare infra- and client-side gyp flags. This adds comparison logic that'll help ensuring client-side gyp flags are the same as the old infra-side ones when switching to MB. Differences will be highlighted at the MB step. Once all bots have switched to MB, the infra-side flags and this CL's logic can be deleted. BUG=616035 TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/96050512c1454313bc1fd88d4dcde379860a7811

Patch Set 1 #

Patch Set 2 : V8: Compare infra- and client-side gyp flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -15 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 3 chunks +64 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 1 chunk +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 1 chunk +18 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 1 chunk +18 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json View 1 chunk +16 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json View 1 chunk +16 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 1 chunk +16 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 3 chunks +44 lines, -3 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 1 chunk +16 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json View 1 chunk +16 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___swarming_staging.json View 1 chunk +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json View 1 chunk +19 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 1 chunk +17 lines, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL
4 years, 6 months ago (2016-06-17 12:15:53 UTC) #4
Michael Achenbach
BTW: I deliberately did't add test cases to cover all the edge cases as this ...
4 years, 6 months ago (2016-06-17 12:16:37 UTC) #5
tandrii(chromium)
lgtm
4 years, 6 months ago (2016-06-17 13:14:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075793003/20001
4 years, 6 months ago (2016-06-17 13:16:38 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 13:20:00 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/96050512c1454313bc1f...

Powered by Google App Engine
This is Rietveld 408576698