scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json - Issue 2075793003: V8: Compare infra- and client-side gyp flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json

Issue 2075793003: V8: Compare infra- and client-side gyp flags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: V8: Compare infra- and client-side gyp flags. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json

index 76e2d0168f381bada18f08d2c0505a3262686638..bad23755098eec739de0c471daa2f85a12b97046 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json

@@ -179,7 +179,22 @@

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

- "name": "generate_build_files"

+ "name": "generate_build_files",

+ "stdout": "/path/to/tmp/",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@stdout@some line@@@",

+ "@@@STEP_LOG_LINE@stdout@GYP_DEFINES='target_arch=x64 cool_flag=a=1'@@@",

+ "@@@STEP_LOG_LINE@stdout@moar@@@",

+ "@@@STEP_LOG_END@stdout@@@",

+ "@@@STEP_LOG_LINE@diff@- gomadir: '[CACHE]/cipd/goma'@@@",

+ "@@@STEP_LOG_LINE@diff@+ cool_flag: a=1@@@",

+ "@@@STEP_LOG_LINE@diff@ target_arch: x64@@@",

+ "@@@STEP_LOG_LINE@diff@- test_isolation_mode: prepare@@@",

+ "@@@STEP_LOG_LINE@diff@- use_goma: 1@@@",

+ "@@@STEP_LOG_LINE@diff@- v8_use_external_startup_data: 0@@@",

+ "@@@STEP_LOG_END@diff@@@",

+ "@@@STEP_WARNINGS@@@"

+ ]

{

"cmd": [