Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2075693002: Always use a /prefetch:# switch when launching a process on Windows. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
gab, jam
CC:
chromium-reviews, nasko+codewatch_chromium.org, sadrul, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, piman+watch_chromium.org, blundell+watchlist_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, wfh+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use a /prefetch:# switch when launching a process on Windows. This CL removes the code to control via a field trial whether a /prefetch:# switch is used when lauching a process. BUG=577698 Committed: https://crrev.com/9a9f0c4e57a85ca7b623a748e5c5bec3b61e034a Cr-Commit-Position: refs/heads/master@{#400514}

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -136 lines) Patch
M chrome/app/chrome_exe_main_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/chrome_watcher_command_line_win.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/service_process_util.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/util/auto_launch_util.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/service/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/service/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 2 chunks +1 line, -4 lines 0 comments Download
M components/crash.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M components/crash/content/app/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M components/nacl.gyp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M components/nacl/browser/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M components/nacl/browser/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/startup_metric_utils/common/pre_read_field_trial_utils_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/startup_metric_utils/common/pre_read_field_trial_utils_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fdoray
gab@: Can you review components/startup_metric_utils/? jam@: Can you review everything else? Thanks!
4 years, 6 months ago (2016-06-16 18:44:49 UTC) #2
jam
lgtm
4 years, 6 months ago (2016-06-16 23:10:55 UTC) #3
gab
lgtm, thanks
4 years, 6 months ago (2016-06-17 18:30:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075693002/40001
4 years, 6 months ago (2016-06-17 18:32:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/22744) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-17 18:35:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075693002/60001
4 years, 6 months ago (2016-06-17 20:36:00 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-17 21:46:45 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 21:48:41 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9a9f0c4e57a85ca7b623a748e5c5bec3b61e034a
Cr-Commit-Position: refs/heads/master@{#400514}

Powered by Google App Engine
This is Rietveld 408576698