components/nacl/browser/nacl_process_host.cc - Issue 2075693002: Always use a /prefetch:# switch when launching a process on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 2075693002: Always use a /prefetch:# switch when launching a process on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index b47ed167504704cedf355284cc04995e1768bf56..45b02d53b1c0a8b132cdab79e44dad1bb5d39868 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -77,7 +77,6 @@

#include "base/win/scoped_handle.h"

#include "components/nacl/browser/nacl_broker_service_win.h"

#include "components/nacl/common/nacl_debug_exception_handler_win.h"

-#include "components/startup_metric_utils/common/pre_read_field_trial_utils_win.h"

#include "content/public/common/sandbox_init.h"

#endif

@@ -645,8 +644,7 @@ bool NaClProcessHost::LaunchSelLdr() {

cmd_line->AppendSwitch(switches::kNoErrorDialogs);

#if defined(OS_WIN)

- if (startup_metric_utils::GetPreReadOptions().use_prefetch_argument)

- cmd_line->AppendArg(switches::kPrefetchArgumentOther);

+ cmd_line->AppendArg(switches::kPrefetchArgumentOther);

#endif // defined(OS_WIN)

// On Windows we might need to start the broker process to launch a new loader

« no previous file with comments | « components/nacl/browser/DEPS ('k') | components/startup_metric_utils/common/pre_read_field_trial_utils_win.h » ('j') | no next file with comments »