Surface button for loading stale cache copy on net error page.

chrome/browser/net/net_error_tab_helper.cc

Index: chrome/browser/net/net_error_tab_helper.cc
diff --git a/chrome/browser/net/net_error_tab_helper.cc b/chrome/browser/net/net_error_tab_helper.cc
index 7112321fa1fa0f2bb550fd08eb0dd71865743930..84246bfb5f2e1cdbfba26dd2f157a1b4b5ce7784 100644
--- a/chrome/browser/net/net_error_tab_helper.cc
+++ b/chrome/browser/net/net_error_tab_helper.cc
@@ -5,6 +5,7 @@
 #include "chrome/browser/net/net_error_tab_helper.h"
 
 #include "base/bind.h"
+#include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/io_thread.h"
@@ -76,6 +77,21 @@ void NetErrorTabHelper::set_state_for_testing(TestingState state) {
   testing_state_ = state;
 }
 
+void NetErrorTabHelper::DidStartNavigationToPendingEntry(
+    const GURL& url,
+    content::NavigationController::ReloadType reload_type) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (reload_type == content::NavigationController::NO_RELOAD)
+    return;
+
+  // Record that we're doing a browser side reload on the error page.
+  if (is_error_page_) {

[mmenke, 2014/04/15 16:02:25]

Think it's a little weird to use early return in the NO_RELOAD check, but not
for the is_error_page_ check.

I'm actually fine with any other combination (early returning on both, including
both in the if, or early returning in the is_error_page_ case first, but then
checking the reload_type in the if - this is the NetErrorTabHelper, afterall).

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

Completely fair.  I opted for the early return if not an error page, then a
commented if conditional.

+    chrome_common_net::RecordEvent(
+        chrome_common_net::NET_ERROR_PAGE_BROWSER_INITIATED_RELOAD);
+  }
+}
+
 void NetErrorTabHelper::DidStartProvisionalLoadForFrame(
     int64 frame_id,
     int64 parent_frame_id,