Surface button for loading stale cache copy on net error page.

chrome/browser/net/net_error_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/net_error_tab_helper.h"
 
 #include "base/bind.h"
+#include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/net/dns_probe_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/net/net_error_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/render_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_frame_host.h"
@@ skipping 51 matching lines @@
 }  // namespace
 
 NetErrorTabHelper::~NetErrorTabHelper() {
 }
 
 // static
 void NetErrorTabHelper::set_state_for_testing(TestingState state) {
   testing_state_ = state;
 }
 
+void NetErrorTabHelper::DidStartNavigationToPendingEntry(
+    const GURL& url,
+    content::NavigationController::ReloadType reload_type) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (reload_type == content::NavigationController::NO_RELOAD)
+    return;
+
+  // Record that we're doing a browser side reload on the error page.
+  if (is_error_page_) {

[mmenke, 2014/04/15 16:02:25]

Think it's a little weird to use early return in the NO_RELOAD check, but not
for the is_error_page_ check.

I'm actually fine with any other combination (early returning on both, including
both in the if, or early returning in the is_error_page_ case first, but then
checking the reload_type in the if - this is the NetErrorTabHelper, afterall).

[Randy Smith (Not in Mondays), 2014/04/15 18:27:29]

Completely fair.  I opted for the early return if not an error page, then a
commented if conditional.

+    chrome_common_net::RecordEvent(
+        chrome_common_net::NET_ERROR_PAGE_BROWSER_INITIATED_RELOAD);
+  }
+}
+
 void NetErrorTabHelper::DidStartProvisionalLoadForFrame(
     int64 frame_id,
     int64 parent_frame_id,
     bool is_main_frame,
     const GURL& validated_url,
     bool is_error_page,
     bool is_iframe_srcdoc,
     RenderViewHost* render_view_host) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
@@ skipping 129 matching lines @@
   DVLOG(1) << "Sending status " << DnsProbeStatusToString(dns_probe_status_);
   content::RenderFrameHost* rfh = web_contents()->GetMainFrame();
   rfh->Send(new ChromeViewMsg_NetErrorInfo(rfh->GetRoutingID(),
                                            dns_probe_status_));
 
   if (!dns_probe_status_snoop_callback_.is_null())
     dns_probe_status_snoop_callback_.Run(dns_probe_status_);
 }
 
 }  // namespace chrome_browser_net