Surface button for loading stale cache copy on net error page.

chrome/renderer/resources/neterror.html

Index: chrome/renderer/resources/neterror.html
diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html
index 63c6a6922064ed8d46bbf5048ef00e1ad244a167..8da3bf3d84765bcc8191941212d91e8d08e18d0e 100644
--- a/chrome/renderer/resources/neterror.html
+++ b/chrome/renderer/resources/neterror.html
@@ -21,12 +21,16 @@
         </h1>
         <div id="buttons">
           <button id="reload-button" class="blue-button text-button"
-              onclick="location = this.url"
-              jsselect="reload" jsvalues=".url:reloadUrl"
+              onclick="helperFunctions.reloadButtonClick();"
+              jsselect="reloadButton" jsvalues=".url:reloadUrl"

[mmenke, 2014/04/09 15:59:26]

jsvalues=".url:reloadUrl" is no longer needed (Can get rid of the field
entirely, actually).

Wonder if we show the cache reload confirmation button if we reload this
way...Probably not, but worth checking.

[Randy Smith (Not in Mondays), 2014/04/10 21:51:01]

Done.
Experimental results:
* Form post -> web page, Browser reload: Prompt the user to make sure they're ok
with it.
* Form post -> error page, browser reload: Prompt.
* Form post -> error page, reload button: No prompt; error page is just
reloaded.
* Form post -> error page, reload button on page -> error page, browser reload:
No prompt. 
* Form post -> error page, reload button on page -> error page, re-enable
network, browser reload: No prompt (and request to server is a GET).

I.e. not only does the reload button on the error page not result in a prompt,
it also turns the internal recording of the page into a GET from a POST.

I dug into this a little bit, and the call into the reload pathway that shows
the warning comes from NavigationControllerImpl::ReloadInternal(), which as
noted earlier is where the browser reload button goes.  The reload button on the
error page goes to blink:WebFrame::reload.  If there's a renderer side function
already existing that hooks into the chromium reload path, we could hook in very
easily, but I'm not aware of one.  If we want the prompt behavior, we're
probably going to need to create an IPC.

               jscontent="msg"></button>
+          <button id="stale-load-button" class="blue-button text-button"
+              onclick="helperFunctions.loadStaleButtonClick()"
+	      jsselect="staleLoadButton"
+	      jscontent="msg" jsvalues="title:title"></button>
           <button id="more-less-button" class="text-button"
-              onclick="toggleHelpBox()" jsdisplay="more"
-              jsvalues=".moreText:more; .lessText:less;"
+              onclick="helperFunctions.moreButtonClick(); toggleHelpBox()"
+	      jsdisplay="more" jsvalues=".moreText:more; .lessText:less;"
               jscontent="more"></button>
         </div>
       </div>