chrome/renderer/resources/neterror.html - Issue 207553008: Surface button for loading stale cache copy on net error page.

Side by Side Diff: chrome/renderer/resources/neterror.html

Issue 207553008: Surface button for loading stale cache copy on net error page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Minor tweaks from self-review. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <meta name="viewport" content="width=device-width, initial-scale=1.0,	5 <meta name="viewport" content="width=device-width, initial-scale=1.0,

6 maximum-scale=1.0, user-scalable=no">	6 maximum-scale=1.0, user-scalable=no">

7 <title i18n-content="title"></title>	7 <title i18n-content="title"></title>

8 <link rel="stylesheet" href="neterror.css">	8 <link rel="stylesheet" href="neterror.css">

9 <script src="neterror.js"></script>	9 <script src="neterror.js"></script>

10 </head>	10 </head>

11 <body id="t">	11 <body id="t">

12 <div id="main-frame-error">	12 <div id="main-frame-error">

13 <div id="box">	13 <div id="box">

14 <div id="content-top">	14 <div id="content-top">

15 <h1>	15 <h1>

16 <div>	16 <div>

17 <img class="icon"	17 <img class="icon"

18 jseval="updateIconClass(this.classList, iconClass)">	18 jseval="updateIconClass(this.classList, iconClass)">

19 </div>	19 </div>

20 <span i18n-content="heading"></span>	20 <span i18n-content="heading"></span>

21 </h1>	21 </h1>

22 <div id="buttons">	22 <div id="buttons">

23 <button id="reload-button" class="blue-button text-button"	23 <button id="reload-button" class="blue-button text-button"

24 onclick="location = this.url"	24 onclick="helperFunctions.reloadButtonClick();"

25 jsselect="reload" jsvalues=".url:reloadUrl"	25 jsselect="reloadButton" jsvalues=".url:reloadUrl"
	mmenke 2014/04/09 15:59:26 jsvalues=".url:reloadUrl" is no longer needed (Can jsvalues=".url:reloadUrl" is no longer needed (Can get rid of the field entirely, actually). Wonder if we show the cache reload confirmation button if we reload this way...Probably not, but worth checking. Randy Smith (Not in Mondays) 2014/04/10 21:51:01 Done. Show quoted text On 2014/04/09 15:59:26, mmenke wrote: > jsvalues=".url:reloadUrl" is no longer needed (Can get rid of the field > entirely, actually). Done. Show quoted text > Wonder if we show the cache reload confirmation button if we reload this > way...Probably not, but worth checking. Experimental results: * Form post -> web page, Browser reload: Prompt the user to make sure they're ok with it. * Form post -> error page, browser reload: Prompt. * Form post -> error page, reload button: No prompt; error page is just reloaded. * Form post -> error page, reload button on page -> error page, browser reload: No prompt. * Form post -> error page, reload button on page -> error page, re-enable network, browser reload: No prompt (and request to server is a GET). I.e. not only does the reload button on the error page not result in a prompt, it also turns the internal recording of the page into a GET from a POST. I dug into this a little bit, and the call into the reload pathway that shows the warning comes from NavigationControllerImpl::ReloadInternal(), which as noted earlier is where the browser reload button goes. The reload button on the error page goes to blink:WebFrame::reload. If there's a renderer side function already existing that hooks into the chromium reload path, we could hook in very easily, but I'm not aware of one. If we want the prompt behavior, we're probably going to need to create an IPC.
26 jscontent="msg"></button>	26 jscontent="msg"></button>

	27 <button id="stale-load-button" class="blue-button text-button"

	28 onclick="helperFunctions.loadStaleButtonClick()"

	29 jsselect="staleLoadButton"

	30 jscontent="msg" jsvalues="title:title"></button>

27 <button id="more-less-button" class="text-button"	31 <button id="more-less-button" class="text-button"

28 onclick="toggleHelpBox()" jsdisplay="more"	32 onclick="helperFunctions.moreButtonClick(); toggleHelpBox()"

29 jsvalues=".moreText:more; .lessText:less;"	33 » jsdisplay="more" jsvalues=".moreText:more; .lessText:less;"

30 jscontent="more"></button>	34 jscontent="more"></button>

31 </div>	35 </div>

32 </div>	36 </div>

33 <!-- Outer and inner divs are needed both for margins and sizing. -->	37 <!-- Outer and inner divs are needed both for margins and sizing. -->

34 <div id="help-box-outer" class="hidden">	38 <div id="help-box-outer" class="hidden">

35 <div id="help-box-inner">	39 <div id="help-box-inner">

36 <div jsselect="summary">	40 <div jsselect="summary">

37 <span jsvalues=".innerHTML:msg"></span>	41 <span jsvalues=".innerHTML:msg"></span>

38 </div>	42 </div>

39 <div class="suggestions" jsselect="suggestions">	43 <div class="suggestions" jsselect="suggestions">

(...skipping 23 matching lines...) Expand all Loading...
63 </div>	67 </div>

64 <div id="sub-frame-error">	68 <div id="sub-frame-error">

65 <!-- Show details when hovering over the icon, in case the details are	69 <!-- Show details when hovering over the icon, in case the details are

66 hidden because they're too large. -->	70 hidden because they're too large. -->

67 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"	71 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"

68 jsvalues=".title:errorDetails">	72 jsvalues=".title:errorDetails">

69 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>	73 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>

70 </div>	74 </div>

71 </body>	75 </body>

72 </html>	76 </html>

OLD	NEW

« chrome/renderer/net/net_error_helper_core.cc ('K') | « chrome/renderer/net/net_error_helper_core_unittest.cc ('k') | chrome/renderer/resources/neterror.js » ('j') | no next file with comments »