Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/permissions/permission_uma_util.h

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.h
diff --git a/chrome/browser/permissions/permission_uma_util.h b/chrome/browser/permissions/permission_uma_util.h
index 2df45b05e43e1ebac5d84916b6ae72fd8695c398..0d24b8415afb199d695c7434706d882e0ea03d1c 100644
--- a/chrome/browser/permissions/permission_uma_util.h
+++ b/chrome/browser/permissions/permission_uma_util.h
@@ -35,6 +35,16 @@ enum PermissionAction {
PERMISSION_ACTION_NUM,
};
+enum SourceUI {
kcarattini 2016/07/06 06:54:08 Add a comment to keep this in sync with the Report
stefanocs 2016/07/07 01:26:03 Done.
+ PROMPT = 0,
+ OIB = 1,
+ SITE_SETTINGS = 2,
+ PAGE_ACTION = 3,
+
+ // Always keep this at the end.
+ SOURCE_UI_NUM,
+};
+
// Provides a convenient way of logging UMA for permission related operations.
class PermissionUmaUtil {
public:
@@ -52,18 +62,23 @@ class PermissionUmaUtil {
Profile* profile);
static void PermissionGranted(content::PermissionType permission,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile);
static void PermissionDenied(content::PermissionType permission,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile);
static void PermissionDismissed(content::PermissionType permission,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile);
static void PermissionIgnored(content::PermissionType permission,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile);
static void PermissionRevoked(content::PermissionType permission,
const GURL& revoked_origin,
+ SourceUI source_ui,
Profile* profile);
// UMA specifically for when permission prompts are shown. This should be
@@ -100,6 +115,7 @@ class PermissionUmaUtil {
static void RecordPermissionAction(content::PermissionType permission,
PermissionAction action,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile);
};

Powered by Google App Engine
This is Rietveld 408576698