Add SourceUI field to permission report

chrome/browser/permissions/permission_uma_util.cc

Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index dce3c3d2d8b04666b350eaff5e96b6c996aeb720..f6a877a65f3ee8375c5cbc7bf995b857c9dcf9e3 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -196,30 +196,39 @@ void PermissionUmaUtil::PermissionRequested(PermissionType permission,
 
 void PermissionUmaUtil::PermissionGranted(PermissionType permission,
                                           const GURL& requesting_origin,
+                                          SourceUI source_ui,
                                           Profile* profile) {
-  RecordPermissionAction(permission, GRANTED, requesting_origin, profile);
+  RecordPermissionAction(permission, GRANTED, requesting_origin, source_ui,
+                         profile);
 }
 
 void PermissionUmaUtil::PermissionDenied(PermissionType permission,
                                          const GURL& requesting_origin,
+                                         SourceUI source_ui,
                                          Profile* profile) {
-  RecordPermissionAction(permission, DENIED, requesting_origin, profile);
+  RecordPermissionAction(permission, DENIED, requesting_origin, source_ui,
+                         profile);
 }
 
 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
                                             const GURL& requesting_origin,
+                                            SourceUI source_ui,
                                             Profile* profile) {
-  RecordPermissionAction(permission, DISMISSED, requesting_origin, profile);
+  RecordPermissionAction(permission, DISMISSED, requesting_origin, source_ui,
+                         profile);
 }
 
 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
                                           const GURL& requesting_origin,
+                                          SourceUI source_ui,
                                           Profile* profile) {
-  RecordPermissionAction(permission, IGNORED, requesting_origin, profile);
+  RecordPermissionAction(permission, IGNORED, requesting_origin, source_ui,
+                         profile);
 }
 
 void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
                                           const GURL& revoked_origin,
+                                          SourceUI source_ui,

[kcarattini, 2016/07/06 06:54:08]

Add a TODO to add reporting for revocations from the Page Action bubbles.

[stefanocs, 2016/07/07 01:26:03]

Done. Revocations from the Page Action bubbles had been recorded but it is
considered as SITE_SETTINGS in this CL
(chrome/browser/permissions/permission_util.cc). So I added a comment below.

                                           Profile* profile) {
   // TODO(tsergeant): Expand metrics definitions for revocation to include all
   // permissions.
@@ -227,7 +236,8 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
       permission == PermissionType::GEOLOCATION ||
       permission == PermissionType::AUDIO_CAPTURE ||
       permission == PermissionType::VIDEO_CAPTURE) {
-    RecordPermissionAction(permission, REVOKED, revoked_origin, profile);
+    RecordPermissionAction(permission, REVOKED, revoked_origin, source_ui,
+                           profile);
   }
 }
 
@@ -339,12 +349,14 @@ bool PermissionUmaUtil::IsOptedInPermissionActionReporting(Profile* profile) {
 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
                                                PermissionAction action,
                                                const GURL& requesting_origin,
+                                               SourceUI source_ui,
                                                Profile* profile) {
   // Send permission action report to opted-in users.
   if (IsOptedInPermissionActionReporting(profile)) {
     g_browser_process->safe_browsing_service()
         ->ui_manager()
-        ->ReportPermissionAction(requesting_origin, permission, action);
+        ->ReportPermissionAction(requesting_origin, permission, action,
+                                 source_ui);
   }
 
   bool secure_origin = content::IsOriginSecure(requesting_origin);