Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove sourceui except from PermissionRevoked Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 37d7d69b5e59b817262f57fb4088b10109f8d2da..f493f2d131d6448dcf66afabb71c1f8d0341c34c 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -197,29 +197,34 @@ void PermissionUmaUtil::PermissionRequested(PermissionType permission,
void PermissionUmaUtil::PermissionGranted(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, GRANTED, requesting_origin, profile);
+ RecordPermissionAction(permission, GRANTED, requesting_origin, PROMPT,
+ profile);
}
void PermissionUmaUtil::PermissionDenied(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, DENIED, requesting_origin, profile);
+ RecordPermissionAction(permission, DENIED, requesting_origin, PROMPT,
+ profile);
}
void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, DISMISSED, requesting_origin, profile);
+ RecordPermissionAction(permission, DISMISSED, requesting_origin, PROMPT,
+ profile);
}
void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
const GURL& requesting_origin,
Profile* profile) {
- RecordPermissionAction(permission, IGNORED, requesting_origin, profile);
+ RecordPermissionAction(permission, IGNORED, requesting_origin, PROMPT,
+ profile);
}
void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
const GURL& revoked_origin,
+ SourceUI source_ui,
Profile* profile) {
// TODO(tsergeant): Expand metrics definitions for revocation to include all
// permissions.
@@ -227,7 +232,8 @@ void PermissionUmaUtil::PermissionRevoked(PermissionType permission,
permission == PermissionType::GEOLOCATION ||
permission == PermissionType::AUDIO_CAPTURE ||
permission == PermissionType::VIDEO_CAPTURE) {
- RecordPermissionAction(permission, REVOKED, revoked_origin, profile);
+ RecordPermissionAction(permission, REVOKED, revoked_origin, source_ui,
+ profile);
}
}
@@ -332,13 +338,15 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
PermissionAction action,
const GURL& requesting_origin,
+ SourceUI source_ui,
Profile* profile) {
if (IsOptedIntoPermissionActionReporting(profile)) {
// TODO(stefanocs): Add browsertests to make sure the reports are being
// sent.
g_browser_process->safe_browsing_service()
->ui_manager()
- ->ReportPermissionAction(requesting_origin, permission, action);
+ ->ReportPermissionAction(requesting_origin, permission, action,
+ source_ui);
}
bool secure_origin = content::IsOriginSecure(requesting_origin);

Powered by Google App Engine
This is Rietveld 408576698