chrome/browser/permissions/permission_util.cc - Issue 2075523002: Add SourceUI field to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_util.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove sourceui except from PermissionRevoked Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_util.cc

diff --git a/chrome/browser/permissions/permission_util.cc b/chrome/browser/permissions/permission_util.cc

index 78271a2c5f2565088a25de0df504fb1a62f93719..8aa3da46b29008b4e8f95715a5ed1afe6469691a 100644

--- a/chrome/browser/permissions/permission_util.cc

+++ b/chrome/browser/permissions/permission_util.cc

@@ -100,8 +100,10 @@ void PermissionUtil::SetContentSettingAndRecordRevocation(

final_value != CONTENT_SETTING_ALLOW) {

PermissionType permission_type;

if (PermissionUtil::GetPermissionType(content_type, &permission_type)) {

+ // TODO(stefanocs): Report revocations from page action as PAGE_ACTION

+ // source UI instead of SITE_SETTINGS source UI.

PermissionUmaUtil::PermissionRevoked(permission_type, primary_url,

- profile);

+ SITE_SETTINGS, profile);

}