Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2775)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment + TODO Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index ab4769e7a7ac95a4c70ff1efb2802faf3f31af3c..b81c6770b7ac49b039246904f895bd3bbb194185 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -283,12 +283,13 @@ void SafeBrowsingUIManager::ReportInvalidCertificateChain(
void SafeBrowsingUIManager::ReportPermissionAction(
const GURL& origin,
content::PermissionType permission,
- PermissionAction action) {
+ PermissionAction action,
+ SourceUI source_ui) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
base::Bind(&SafeBrowsingUIManager::ReportPermissionActionOnIOThread, this,
- origin, permission, action));
+ origin, permission, action, source_ui));
}
void SafeBrowsingUIManager::AddObserver(Observer* observer) {
@@ -316,7 +317,8 @@ void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
const GURL& origin,
content::PermissionType permission,
- PermissionAction action) {
+ PermissionAction action,
+ SourceUI source_ui) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// The service may delete the ping manager (i.e. when user disabling service,
@@ -325,7 +327,7 @@ void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
return;
sb_service_->ping_manager()->ReportPermissionAction(origin, permission,
- action);
+ action, source_ui);
}
// If the user had opted-in to send ThreatDetails, this gets called

Powered by Google App Engine
This is Rietveld 408576698