chrome/browser/safe_browsing/ping_manager.cc - Issue 2075523002: Add SourceUI field to permission report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 2075523002: Add SourceUI field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment + TODO Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/ping_manager.cc

diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc

index 74d4f4e52e114c01fc79efcfd4aa84e7e49f9622..518d60c13fd8f0ac797d83cfcc50adfe13601d90 100644

--- a/chrome/browser/safe_browsing/ping_manager.cc

+++ b/chrome/browser/safe_browsing/ping_manager.cc

@@ -136,8 +136,9 @@ void SafeBrowsingPingManager::SetCertificateErrorReporterForTesting(

void SafeBrowsingPingManager::ReportPermissionAction(

const GURL& origin,

content::PermissionType permission,

- PermissionAction action) {

- permission_reporter_->SendReport(origin, permission, action);

+ PermissionAction action,

+ SourceUI source_ui) {

+ permission_reporter_->SendReport(origin, permission, action, source_ui);

}

GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(