Remove IconLabelView layout constants.

Remove IconLabelView layout constants.

With the new IconLabelView design, we just want to use
LOCATION_BAR_HORIZONTAL_PADDING everywhere, except for the trailing padding in
non-MD, which I'm making a class-scoped constant for now (we can delete it
entirely when non-MD goes away).

This increases the internal spacing in MD from 5 to 6, which is correct for the
new style.

BUG=616191
TEST=none

Committed: https://crrev.com/a4123685765478a14349e959be9ca83545b4c06c
Cr-Commit-Position: refs/heads/master@{#400092}

[Peter Kasting, 2016-06-15 21:36:12]

pkasting@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-06-15 23:08:41]

lgtm

https://codereview.chromium.org/2075443002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.h (right):

https://codereview.chromium.org/2075443002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.h:34: static
constexpr int kTrailingPaddingPreMD = 2;
nit: Md

[Peter Kasting, 2016-06-16 04:39:09]

https://codereview.chromium.org/2075443002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/icon_label_bubble_view.h (right):

https://codereview.chromium.org/2075443002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/icon_label_bubble_view.h:34: static
constexpr int kTrailingPaddingPreMD = 2;
On 2016/06/15 23:08:41, Evan Stade wrote:
> nit: Md

Done.

[Peter Kasting, 2016-06-16 04:39:13]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-06-16 04:39:13]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2075443002/#ps20001
(title: "Review comment, fix compile")

[commit-bot: I haz the power, 2016-06-16 04:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075443002/20001

[commit-bot: I haz the power, 2016-06-16 05:52:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-16 05:52:45]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 05:54:24]

Description was changed from

==========
Remove IconLabelView layout constants.

With the new IconLabelView design, we just want to use
LOCATION_BAR_HORIZONTAL_PADDING everywhere, except for the trailing padding in
non-MD, which I'm making a class-scoped constant for now (we can delete it
entirely when non-MD goes away).

This increases the internal spacing in MD from 5 to 6, which is correct for the
new style.

BUG=616191
TEST=none
==========

to

==========
Remove IconLabelView layout constants.

With the new IconLabelView design, we just want to use
LOCATION_BAR_HORIZONTAL_PADDING everywhere, except for the trailing padding in
non-MD, which I'm making a class-scoped constant for now (we can delete it
entirely when non-MD goes away).

This increases the internal spacing in MD from 5 to 6, which is correct for the
new style.

BUG=616191
TEST=none

Committed: https://crrev.com/a4123685765478a14349e959be9ca83545b4c06c
Cr-Commit-Position: refs/heads/master@{#400092}
==========

[commit-bot: I haz the power, 2016-06-16 05:54:25]

Patchset 2 (id:??) landed as
https://crrev.com/a4123685765478a14349e959be9ca83545b4c06c
Cr-Commit-Position: refs/heads/master@{#400092}