chrome/browser/ui/views/location_bar/keyword_hint_view.cc - Issue 2075443002: Remove IconLabelView layout constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/keyword_hint_view.cc

Issue 2075443002: Remove IconLabelView layout constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment, fix compile Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/keyword_hint_view.cc

diff --git a/chrome/browser/ui/views/location_bar/keyword_hint_view.cc b/chrome/browser/ui/views/location_bar/keyword_hint_view.cc

index 2480de90634a318d69101008498dde22ddd031eb..76fd3fb9116dab85643199c7364b1daf05a11089 100644

--- a/chrome/browser/ui/views/location_bar/keyword_hint_view.cc

+++ b/chrome/browser/ui/views/location_bar/keyword_hint_view.cc

@@ -57,7 +57,9 @@ TabKeyBubbleView::~TabKeyBubbleView() {}

gfx::Size TabKeyBubbleView::GetPreferredSize() const {

gfx::Size size = views::Label::GetPreferredSize();

- size.Enlarge(2 * GetLayoutConstant(ICON_LABEL_VIEW_TRAILING_PADDING), 0);

+ constexpr int kPaddingInsideBorder = 5;

+ // Even though the border is 1 px thick visibly, it takes 1 DIP logically.

+ size.Enlarge(2 * (kPaddingInsideBorder + 1), 0);

return size;

}