Use full available height when sizing percent content in cells

Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box a second time to cells like that: the available height to
its content is already constrained by the content box.

I can't now see any good reason for why I did that - I think was erroneously trying
to match old, incorrect behaviour in some results.

BUG=620326
Committed: https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0
Cr-Commit-Position: refs/heads/master@{#402748}

[rhogan, 2016-06-28 17:48:48]

Description was changed from

==========
Use full available height when sizing percent content in cells

BUG=620326
==========

to

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box to cells like that. 

BUG=620326
==========

[rhogan, 2016-06-28 17:48:48]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2016-06-28 17:50:15]

Description was changed from

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box to cells like that. 

BUG=620326
==========

to

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box to cells like that: the available height to
its content is the full available height.

BUG=620326
==========

[rhogan, 2016-06-28 17:51:46]

Description was changed from

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box to cells like that: the available height to
its content is the full available height.

BUG=620326
==========

to

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box a second time to cells like that: the
available height to
its content is already constrained by the content box.

I can't now see any good reason for why I did that - I think was erroneously
trying
to match old, incorrect behaviour in some results.

BUG=620326
==========

[eae, 2016-06-28 18:05:07]

Makes more sense and I like the test coverage.

LGTM

[eae, 2016-06-28 18:05:34]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-06-28 18:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 18:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 18:10:14]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2016-06-29 06:06:51]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-06-29 06:06:52]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2075393002/#ps40001
(title: "bug 620326")

[commit-bot: I haz the power, 2016-06-29 06:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 07:30:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 07:33:32]

Description was changed from

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box a second time to cells like that: the
available height to
its content is already constrained by the content box.

I can't now see any good reason for why I did that - I think was erroneously
trying
to match old, incorrect behaviour in some results.

BUG=620326
==========

to

==========
Use full available height when sizing percent content in cells

This was an error in https://codereview.chromium.org/2037783002. I shouldn't be
baking in the notion of content-box a second time to cells like that: the
available height to
its content is already constrained by the content box.

I can't now see any good reason for why I did that - I think was erroneously
trying
to match old, incorrect behaviour in some results.

BUG=620326

Committed: https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0
Cr-Commit-Position: refs/heads/master@{#402748}
==========

[commit-bot: I haz the power, 2016-06-29 07:33:33]

Patchset 3 (id:??) landed as
https://crrev.com/1afb8400a1d933cd50a16947899b0d88d2d30fb0
Cr-Commit-Position: refs/heads/master@{#402748}