Percent height content should respect the fixed height of its containing cell

Percent height content should respect the fixed height of its containing cell

Reland: https://codereview.chromium.org/992483002

When an element in a cell has a percent height and the cell has a fixed height we
currently let the element ignore the height on the cell and instead let its content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096, 468699
Committed: https://crrev.com/28307938a3f600ff4ade76939ae7c03f617b7df5
Cr-Commit-Position: refs/heads/master@{#397799}

[rhogan, 2016-06-02 19:33:04]

Description was changed from

==========
Percent height content should respect the fixed height of its containing cell

BUG=465096
==========

to

==========
Percent height content should respect the fixed height of its containing cell

Reland: https://codereview.chromium.org/992483002

When an element in a cell has a percent height and the cell has a fixed height
we
currently let the element ignore the height on the cell and instead let its
content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096,468699
==========

[rhogan, 2016-06-02 19:33:42]

robhogan@gmail.com changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[eae, 2016-06-02 22:50:34]

LGTM w/nit

https://codereview.chromium.org/2037783002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2037783002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2758: availableHeight =
std::max(LayoutUnit(),
cb->constrainContentBoxLogicalHeightByMinMax(contentBoxHeight -
cb->scrollbarLogicalHeight(), LayoutUnit(-1)));
Please wrap this line. Also consider using clampNegativeToZero.

Perhaps something like
availableHeight = cb>constrainContentBoxLogicalHeightByMinMax(
        contentBoxHeight - cb->scrollbarLogicalHeight(),
        LayoutUnit(-1)
    ).clampNegativeToZero();

or using a local variable

LayoutUnit minHeight = contentBoxHeight - cb->scrollbarLogicalHeight();
availableHeight = cb>constrainContentBoxLogicalHeightByMinMax(minHeight,
    LayoutUnit(-1)).clampNegativeToZero();

[rhogan, 2016-06-03 19:07:56]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-06-03 19:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2037783002/#ps40001
(title: "Updated")

[commit-bot: I haz the power, 2016-06-03 19:08:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037783002/40001

[commit-bot: I haz the power, 2016-06-03 20:56:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 20:57:37]

Description was changed from

==========
Percent height content should respect the fixed height of its containing cell

Reland: https://codereview.chromium.org/992483002

When an element in a cell has a percent height and the cell has a fixed height
we
currently let the element ignore the height on the cell and instead let its
content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096,468699
==========

to

==========
Percent height content should respect the fixed height of its containing cell

Reland: https://codereview.chromium.org/992483002

When an element in a cell has a percent height and the cell has a fixed height
we
currently let the element ignore the height on the cell and instead let its
content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096,468699

Committed: https://crrev.com/28307938a3f600ff4ade76939ae7c03f617b7df5
Cr-Commit-Position: refs/heads/master@{#397799}
==========

[commit-bot: I haz the power, 2016-06-03 20:57:38]

Patchset 3 (id:??) landed as
https://crrev.com/28307938a3f600ff4ade76939ae7c03f617b7df5
Cr-Commit-Position: refs/heads/master@{#397799}