Remove some fx_dib functions with unused parameters.

Remove some fx_dib functions with unused parameters.

Committed: https://pdfium.googlesource.com/pdfium/+/726b3db9b05c785923c65a260c59a9a9190c29e0

[Lei Zhang, 2016-06-20 16:20:37]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-06-20 16:20:38]

https://codereview.chromium.org/2075383002/diff/1/core/fxge/ge/fx_ge_text.cpp
File core/fxge/ge/fx_ge_text.cpp (left):

https://codereview.chromium.org/2075383002/diff/1/core/fxge/ge/fx_ge_text.cpp...
core/fxge/ge/fx_ge_text.cpp:371: if (!pIccTransform &&
!FXGETFLAG_COLORTYPE(alpha_flag)) {
The two possible values of |alpha_flag| are 0 and 1 << 24, both of which evals
to false with FXGETFLAG_COLORTYPE(), so we always take the early return path.
All callers actually pass in the same variable for |argb| and |color|.

[dsinclair, 2016-06-20 17:20:19]

dsinclair@chromium.org changed reviewers:
+ caryclark@chromium.org

[dsinclair, 2016-06-20 17:20:20]

lg w/ nits. caryclark@ is this good from the Skia side?

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
File core/fxge/dib/fx_dib_convert.cpp (right):

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:180: uint8_t reset_r, reset_g, reset_b, set_r,
set_g, set_b;
nit: one per line.

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:223: uint8_t r, g, b;
ditto

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:327: uint8_t r, g, b;
ditto

[Lei Zhang, 2016-06-21 18:10:45]

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
File core/fxge/dib/fx_dib_convert.cpp (right):

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:180: uint8_t reset_r, reset_g, reset_b, set_r,
set_g, set_b;
On 2016/06/20 17:20:20, dsinclair wrote:
> nit: one per line.

Done.

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:223: uint8_t r, g, b;
On 2016/06/20 17:20:20, dsinclair wrote:
> ditto

Done.

https://codereview.chromium.org/2075383002/diff/1/core/fxge/dib/fx_dib_conver...
core/fxge/dib/fx_dib_convert.cpp:327: uint8_t r, g, b;
On 2016/06/20 17:20:20, dsinclair wrote:
> ditto

Done.

[Lei Zhang, 2016-06-21 18:15:58]

I remembered to build for Skia on Linux. See patch set 4.

[dsinclair, 2016-06-21 19:48:09]

lgtm

[Lei Zhang, 2016-06-21 20:20:31]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-21 20:20:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075383002/60001

[commit-bot: I haz the power, 2016-06-21 20:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 20:21:31]

Try jobs failed on following builders:
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, no build URL)

[dsinclair, 2016-06-22 14:03:27]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-06-22 14:03:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075383002/60001

[commit-bot: I haz the power, 2016-06-22 14:29:11]

Description was changed from

==========
Remove some fx_dib functions with unused parameters.
==========

to

==========
Remove some fx_dib functions with unused parameters.

Committed:
https://pdfium.googlesource.com/pdfium/+/726b3db9b05c785923c65a260c59a9a9190c...
==========

[commit-bot: I haz the power, 2016-06-22 14:29:14]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/726b3db9b05c785923c65a260c59a9a9190c...