Remove some fx_dib functions with unused parameters.

core/fxge/dib/fx_dib_convert.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fxcodec/include/fx_codec.h"
 #include "core/fxge/include/fx_dib.h"
 #include "core/fxge/include/fx_ge.h"
 
@@ skipping 156 matching lines @@
     FXSYS_memcpy(dest_scan, src_scan, width);
   }
   return TRUE;
 }
 FX_BOOL ConvertBuffer_1bppPlt2Gray(uint8_t* dest_buf,
                                    int dest_pitch,
                                    int width,
                                    int height,
                                    const CFX_DIBSource* pSrcBitmap,
                                    int src_left,
-                                   int src_top,
-                                   void* pIccTransform) {
+                                   int src_top) {
   uint32_t* src_plt = pSrcBitmap->GetPalette();
   uint8_t gray[2];
-  if (pIccTransform) {
-    uint32_t plt[2];
-    if (pSrcBitmap->IsCmykImage()) {
-      plt[0] = FXCMYK_TODIB(src_plt[0]);
-      plt[1] = FXCMYK_TODIB(src_plt[1]);
-    } else {
-      uint8_t* bgr_ptr = (uint8_t*)plt;
-      bgr_ptr[0] = FXARGB_B(src_plt[0]);
-      bgr_ptr[1] = FXARGB_G(src_plt[0]);
-      bgr_ptr[2] = FXARGB_R(src_plt[0]);
-      bgr_ptr[3] = FXARGB_B(src_plt[1]);
-      bgr_ptr[4] = FXARGB_G(src_plt[1]);
-      bgr_ptr[5] = FXARGB_R(src_plt[1]);
-    }
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    pIccModule->TranslateScanline(pIccTransform, gray, (const uint8_t*)plt, 2);
+  uint8_t reset_r, reset_g, reset_b, set_r, set_g, set_b;

[dsinclair, 2016/06/20 17:20:20]

nit: one per line.

[Lei Zhang, 2016/06/21 18:10:44]

Done.

+  if (pSrcBitmap->IsCmykImage()) {
+    AdobeCMYK_to_sRGB1(FXSYS_GetCValue(src_plt[0]), FXSYS_GetMValue(src_plt[0]),
+                       FXSYS_GetYValue(src_plt[0]), FXSYS_GetKValue(src_plt[0]),
+                       reset_r, reset_g, reset_b);
+    AdobeCMYK_to_sRGB1(FXSYS_GetCValue(src_plt[1]), FXSYS_GetMValue(src_plt[1]),
+                       FXSYS_GetYValue(src_plt[1]), FXSYS_GetKValue(src_plt[1]),
+                       set_r, set_g, set_b);
   } else {
-    uint8_t reset_r, reset_g, reset_b, set_r, set_g, set_b;
-    if (pSrcBitmap->IsCmykImage()) {
-      AdobeCMYK_to_sRGB1(
-          FXSYS_GetCValue(src_plt[0]), FXSYS_GetMValue(src_plt[0]),
-          FXSYS_GetYValue(src_plt[0]), FXSYS_GetKValue(src_plt[0]), reset_r,
-          reset_g, reset_b);
-      AdobeCMYK_to_sRGB1(FXSYS_GetCValue(src_plt[1]),
-                         FXSYS_GetMValue(src_plt[1]),
-                         FXSYS_GetYValue(src_plt[1]),
-                         FXSYS_GetKValue(src_plt[1]), set_r, set_g, set_b);
-    } else {
-      reset_r = FXARGB_R(src_plt[0]);
-      reset_g = FXARGB_G(src_plt[0]);
-      reset_b = FXARGB_B(src_plt[0]);
-      set_r = FXARGB_R(src_plt[1]);
-      set_g = FXARGB_G(src_plt[1]);
-      set_b = FXARGB_B(src_plt[1]);
-    }
-    gray[0] = FXRGB2GRAY(reset_r, reset_g, reset_b);
-    gray[1] = FXRGB2GRAY(set_r, set_g, set_b);
+    reset_r = FXARGB_R(src_plt[0]);
+    reset_g = FXARGB_G(src_plt[0]);
+    reset_b = FXARGB_B(src_plt[0]);
+    set_r = FXARGB_R(src_plt[1]);
+    set_g = FXARGB_G(src_plt[1]);
+    set_b = FXARGB_B(src_plt[1]);
   }
+  gray[0] = FXRGB2GRAY(reset_r, reset_g, reset_b);
+  gray[1] = FXRGB2GRAY(set_r, set_g, set_b);
+
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     FXSYS_memset(dest_scan, gray[0], width);
     const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row);
     for (int col = src_left; col < src_left + width; col++) {
       if (src_scan[col / 8] & (1 << (7 - col % 8))) {
         *dest_scan = gray[1];
       }
       dest_scan++;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_8bppPlt2Gray(uint8_t* dest_buf,
                                    int dest_pitch,
                                    int width,
                                    int height,
                                    const CFX_DIBSource* pSrcBitmap,
                                    int src_left,
-                                   int src_top,
-                                   void* pIccTransform) {
+                                   int src_top) {
   uint32_t* src_plt = pSrcBitmap->GetPalette();
   uint8_t gray[256];
-  if (pIccTransform) {
-    uint32_t plt[256];
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int i = 0; i < 256; i++) {
-        plt[i] = FXCMYK_TODIB(src_plt[i]);
-      }
-    } else {
-      uint8_t* bgr_ptr = (uint8_t*)plt;
-      for (int i = 0; i < 256; i++) {
-        *bgr_ptr++ = FXARGB_B(src_plt[i]);
-        *bgr_ptr++ = FXARGB_G(src_plt[i]);
-        *bgr_ptr++ = FXARGB_R(src_plt[i]);
-      }
+  if (pSrcBitmap->IsCmykImage()) {
+    uint8_t r, g, b;

[dsinclair, 2016/06/20 17:20:20]

ditto

[Lei Zhang, 2016/06/21 18:10:44]

Done.

+    for (int i = 0; i < 256; i++) {
+      AdobeCMYK_to_sRGB1(
+          FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
+          FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]), r, g, b);
+      gray[i] = FXRGB2GRAY(r, g, b);
     }
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    pIccModule->TranslateScanline(pIccTransform, gray, (const uint8_t*)plt,
-                                  256);
   } else {
-    if (pSrcBitmap->IsCmykImage()) {
-      uint8_t r, g, b;
-      for (int i = 0; i < 256; i++) {
-        AdobeCMYK_to_sRGB1(
-            FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
-            FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]), r, g, b);
-        gray[i] = FXRGB2GRAY(r, g, b);
-      }
-    } else {
-      for (int i = 0; i < 256; i++) {
-        gray[i] = FXRGB2GRAY(FXARGB_R(src_plt[i]), FXARGB_G(src_plt[i]),
-                             FXARGB_B(src_plt[i]));
-      }
+    for (int i = 0; i < 256; i++) {
+      gray[i] = FXRGB2GRAY(FXARGB_R(src_plt[i]), FXARGB_G(src_plt[i]),
+                           FXARGB_B(src_plt[i]));
     }
   }
+
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row) + src_left;
     for (int col = 0; col < width; col++) {
       *dest_scan++ = gray[*src_scan++];
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_RgbOrCmyk2Gray(uint8_t* dest_buf,
                                      int dest_pitch,
                                      int width,
                                      int height,
                                      const CFX_DIBSource* pSrcBitmap,
                                      int src_left,
-                                     int src_top,
-                                     void* pIccTransform) {
+                                     int src_top) {
   int Bpp = pSrcBitmap->GetBPP() / 8;
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    if (Bpp == 3 || pSrcBitmap->IsCmykImage()) {
-      for (int row = 0; row < height; row++) {
-        uint8_t* dest_scan = dest_buf + row * dest_pitch;
-        const uint8_t* src_scan =
-            pSrcBitmap->GetScanline(src_top + row) + src_left * Bpp;
-        pIccModule->TranslateScanline(pIccTransform, dest_scan, src_scan,
-                                      width);
-      }
-    } else {
-      for (int row = 0; row < height; row++) {
-        uint8_t* dest_scan = dest_buf + row * dest_pitch;
-        const uint8_t* src_scan =
-            pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
-        for (int col = 0; col < width; col++) {
-          pIccModule->TranslateScanline(pIccTransform, dest_scan, src_scan, 1);
-          dest_scan++;
-          src_scan += 4;
-        }
+  if (pSrcBitmap->IsCmykImage()) {
+    for (int row = 0; row < height; row++) {
+      uint8_t* dest_scan = dest_buf + row * dest_pitch;
+      const uint8_t* src_scan =
+          pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
+      for (int col = 0; col < width; col++) {
+        uint8_t r, g, b;
+        AdobeCMYK_to_sRGB1(FXSYS_GetCValue((uint32_t)src_scan[0]),
+                           FXSYS_GetMValue((uint32_t)src_scan[1]),
+                           FXSYS_GetYValue((uint32_t)src_scan[2]),
+                           FXSYS_GetKValue((uint32_t)src_scan[3]), r, g, b);
+        *dest_scan++ = FXRGB2GRAY(r, g, b);
+        src_scan += 4;
       }
     }
   } else {
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int row = 0; row < height; row++) {
-        uint8_t* dest_scan = dest_buf + row * dest_pitch;
-        const uint8_t* src_scan =
-            pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
-        for (int col = 0; col < width; col++) {
-          uint8_t r, g, b;
-          AdobeCMYK_to_sRGB1(FXSYS_GetCValue((uint32_t)src_scan[0]),
-                             FXSYS_GetMValue((uint32_t)src_scan[1]),
-                             FXSYS_GetYValue((uint32_t)src_scan[2]),
-                             FXSYS_GetKValue((uint32_t)src_scan[3]), r, g, b);
-          *dest_scan++ = FXRGB2GRAY(r, g, b);
-          src_scan += 4;
-        }
-      }
-    } else {
-      for (int row = 0; row < height; row++) {
-        uint8_t* dest_scan = dest_buf + row * dest_pitch;
-        const uint8_t* src_scan =
-            pSrcBitmap->GetScanline(src_top + row) + src_left * Bpp;
-        for (int col = 0; col < width; col++) {
-          *dest_scan++ = FXRGB2GRAY(src_scan[2], src_scan[1], src_scan[0]);
-          src_scan += Bpp;
-        }
+    for (int row = 0; row < height; row++) {
+      uint8_t* dest_scan = dest_buf + row * dest_pitch;
+      const uint8_t* src_scan =
+          pSrcBitmap->GetScanline(src_top + row) + src_left * Bpp;
+      for (int col = 0; col < width; col++) {
+        *dest_scan++ = FXRGB2GRAY(src_scan[2], src_scan[1], src_scan[0]);
+        src_scan += Bpp;
       }
     }
   }
   return TRUE;
 }
-inline void ConvertBuffer_IndexCopy(uint8_t* dest_buf,
-                                    int dest_pitch,
-                                    int width,
-                                    int height,
-                                    const CFX_DIBSource* pSrcBitmap,
-                                    int src_left,
-                                    int src_top) {
+
+void ConvertBuffer_IndexCopy(uint8_t* dest_buf,
+                             int dest_pitch,
+                             int width,
+                             int height,
+                             const CFX_DIBSource* pSrcBitmap,
+                             int src_left,
+                             int src_top) {
   if (pSrcBitmap->GetBPP() == 1) {
     for (int row = 0; row < height; row++) {
       uint8_t* dest_scan = dest_buf + row * dest_pitch;
       FXSYS_memset(dest_scan, 0, width);
       const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row);
       for (int col = src_left; col < src_left + width; col++) {
         if (src_scan[col / 8] & (1 << (7 - col % 8))) {
           *dest_scan = 1;
         }
         dest_scan++;
       }
     }
   } else {
     for (int row = 0; row < height; row++) {
       uint8_t* dest_scan = dest_buf + row * dest_pitch;
       const uint8_t* src_scan =
           pSrcBitmap->GetScanline(src_top + row) + src_left;
       FXSYS_memcpy(dest_scan, src_scan, width);
     }
   }
 }
+
 FX_BOOL ConvertBuffer_Plt2PltRgb8(uint8_t* dest_buf,
                                   int dest_pitch,
                                   int width,
                                   int height,
                                   const CFX_DIBSource* pSrcBitmap,
                                   int src_left,
                                   int src_top,
-                                  uint32_t* dst_plt,
-                                  void* pIccTransform) {
+                                  uint32_t* dst_plt) {
   ConvertBuffer_IndexCopy(dest_buf, dest_pitch, width, height, pSrcBitmap,
                           src_left, src_top);
   uint32_t* src_plt = pSrcBitmap->GetPalette();
   int plt_size = pSrcBitmap->GetPaletteSize();
-  if (pIccTransform) {
-    uint32_t plt[256];
-    uint8_t* bgr_ptr = (uint8_t*)plt;
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int i = 0; i < plt_size; i++) {
-        plt[i] = FXCMYK_TODIB(src_plt[i]);
-      }
-    } else {
-      for (int i = 0; i < plt_size; i++) {
-        *bgr_ptr++ = FXARGB_B(src_plt[i]);
-        *bgr_ptr++ = FXARGB_G(src_plt[i]);
-        *bgr_ptr++ = FXARGB_R(src_plt[i]);
-      }
-      bgr_ptr = (uint8_t*)plt;
-    }
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    pIccModule->TranslateScanline(pIccTransform, (uint8_t*)plt,
-                                  (const uint8_t*)plt, plt_size);
+  if (pSrcBitmap->IsCmykImage()) {
     for (int i = 0; i < plt_size; i++) {
-      dst_plt[i] = FXARGB_MAKE(0xff, bgr_ptr[2], bgr_ptr[1], bgr_ptr[0]);
-      bgr_ptr += 3;
+      uint8_t r, g, b;

[dsinclair, 2016/06/20 17:20:20]

ditto

[Lei Zhang, 2016/06/21 18:10:44]

Done.

+      AdobeCMYK_to_sRGB1(
+          FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
+          FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]), r, g, b);
+      dst_plt[i] = FXARGB_MAKE(0xff, r, g, b);
     }
   } else {
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int i = 0; i < plt_size; i++) {
-        uint8_t r, g, b;
-        AdobeCMYK_to_sRGB1(
-            FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
-            FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]), r, g, b);
-        dst_plt[i] = FXARGB_MAKE(0xff, r, g, b);
-      }
-    } else {
-      FXSYS_memcpy(dst_plt, src_plt, plt_size * 4);
-    }
+    FXSYS_memcpy(dst_plt, src_plt, plt_size * 4);
   }
   return TRUE;
 }
-FX_BOOL ConvertBuffer_Rgb2PltRgb8_NoTransform(uint8_t* dest_buf,
-                                              int dest_pitch,
-                                              int width,
-                                              int height,
-                                              const CFX_DIBSource* pSrcBitmap,
-                                              int src_left,
-                                              int src_top,
-                                              uint32_t* dst_plt) {
+
+FX_BOOL ConvertBuffer_Rgb2PltRgb8(uint8_t* dest_buf,
+                                  int dest_pitch,
+                                  int width,
+                                  int height,
+                                  const CFX_DIBSource* pSrcBitmap,
+                                  int src_left,
+                                  int src_top,
+                                  uint32_t* dst_plt) {
   int bpp = pSrcBitmap->GetBPP() / 8;
   CFX_Palette palette;
   palette.BuildPalette(pSrcBitmap);
   uint32_t* cLut = palette.GetColorLut();
   uint32_t* aLut = palette.GetAmountLut();
   if (!cLut || !aLut) {
     return FALSE;
   }
   int lut = palette.Getlut();
   uint32_t* pPalette = palette.GetPalette();
@@ skipping 33 matching lines @@
       for (int i = lut_1; i >= 0; i--)
         if (clrindex == cLut[i]) {
           *(dest_scan + col) = (uint8_t)(aLut[i]);
           break;
         }
     }
   }
   FXSYS_memcpy(dst_plt, pPalette, sizeof(uint32_t) * 256);
   return TRUE;
 }
-FX_BOOL ConvertBuffer_Rgb2PltRgb8(uint8_t* dest_buf,
-                                  int dest_pitch,
-                                  int width,
-                                  int height,
-                                  const CFX_DIBSource* pSrcBitmap,
-                                  int src_left,
-                                  int src_top,
-                                  uint32_t* dst_plt,
-                                  void* pIccTransform) {
-  FX_BOOL ret = ConvertBuffer_Rgb2PltRgb8_NoTransform(
-      dest_buf, dest_pitch, width, height, pSrcBitmap, src_left, src_top,
-      dst_plt);
-  if (ret && pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    for (int i = 0; i < 256; i++) {
-      FX_ARGB* plt = dst_plt + i;
-      FX_ARGB plt_entry = FXARGB_TODIB(*plt);
-      pIccModule->TranslateScanline(pIccTransform, (uint8_t*)&plt_entry,
-                                    (const uint8_t*)&plt_entry, 1);
-      *plt = FXARGB_TODIB(plt_entry);
-    }
-  }
-  return ret;
-}
+
 FX_BOOL ConvertBuffer_1bppMask2Rgb(FXDIB_Format dst_format,
                                    uint8_t* dest_buf,
                                    int dest_pitch,
                                    int width,
                                    int height,
                                    const CFX_DIBSource* pSrcBitmap,
                                    int src_left,
                                    int src_top) {
   int comps = (dst_format & 0xff) / 8;
   uint8_t set_gray, reset_gray;
@@ skipping 10 matching lines @@
       } else {
         dest_scan[0] = reset_gray;
         dest_scan[1] = reset_gray;
         dest_scan[2] = reset_gray;
       }
       dest_scan += comps;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_8bppMask2Rgb(FXDIB_Format dst_format,
                                    uint8_t* dest_buf,
                                    int dest_pitch,
                                    int width,
                                    int height,
                                    const CFX_DIBSource* pSrcBitmap,
                                    int src_left,
                                    int src_top) {
   int comps = (dst_format & 0xff) / 8;
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row) + src_left;
     uint8_t src_pixel;
     for (int col = 0; col < width; col++) {
       src_pixel = *src_scan++;
       *dest_scan++ = src_pixel;
       *dest_scan++ = src_pixel;
       *dest_scan = src_pixel;
       dest_scan += comps - 2;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_1bppPlt2Rgb(FXDIB_Format dst_format,
                                   uint8_t* dest_buf,
                                   int dest_pitch,
                                   int width,
                                   int height,
                                   const CFX_DIBSource* pSrcBitmap,
                                   int src_left,
-                                  int src_top,
-                                  void* pIccTransform) {
+                                  int src_top) {
   int comps = (dst_format & 0xff) / 8;
   uint32_t* src_plt = pSrcBitmap->GetPalette();
   uint32_t plt[2];
   uint8_t* bgr_ptr = (uint8_t*)plt;
   if (pSrcBitmap->IsCmykImage()) {
     plt[0] = FXCMYK_TODIB(src_plt[0]);
     plt[1] = FXCMYK_TODIB(src_plt[1]);
   } else {
     bgr_ptr[0] = FXARGB_B(src_plt[0]);
     bgr_ptr[1] = FXARGB_G(src_plt[0]);
     bgr_ptr[2] = FXARGB_R(src_plt[0]);
     bgr_ptr[3] = FXARGB_B(src_plt[1]);
     bgr_ptr[4] = FXARGB_G(src_plt[1]);
     bgr_ptr[5] = FXARGB_R(src_plt[1]);
   }
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    pIccModule->TranslateScanline(pIccTransform, (uint8_t*)plt,
-                                  (const uint8_t*)plt, 2);
-  } else {
-    if (pSrcBitmap->IsCmykImage()) {
-      AdobeCMYK_to_sRGB1(
-          FXSYS_GetCValue(src_plt[0]), FXSYS_GetMValue(src_plt[0]),
-          FXSYS_GetYValue(src_plt[0]), FXSYS_GetKValue(src_plt[0]), bgr_ptr[2],
-          bgr_ptr[1], bgr_ptr[0]);
-      AdobeCMYK_to_sRGB1(
-          FXSYS_GetCValue(src_plt[1]), FXSYS_GetMValue(src_plt[1]),
-          FXSYS_GetYValue(src_plt[1]), FXSYS_GetKValue(src_plt[1]), bgr_ptr[5],
-          bgr_ptr[4], bgr_ptr[3]);
-    }
+
+  if (pSrcBitmap->IsCmykImage()) {
+    AdobeCMYK_to_sRGB1(FXSYS_GetCValue(src_plt[0]), FXSYS_GetMValue(src_plt[0]),
+                       FXSYS_GetYValue(src_plt[0]), FXSYS_GetKValue(src_plt[0]),
+                       bgr_ptr[2], bgr_ptr[1], bgr_ptr[0]);
+    AdobeCMYK_to_sRGB1(FXSYS_GetCValue(src_plt[1]), FXSYS_GetMValue(src_plt[1]),
+                       FXSYS_GetYValue(src_plt[1]), FXSYS_GetKValue(src_plt[1]),
+                       bgr_ptr[5], bgr_ptr[4], bgr_ptr[3]);
   }
+
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row);
     for (int col = src_left; col < src_left + width; col++) {
       if (src_scan[col / 8] & (1 << (7 - col % 8))) {
         *dest_scan++ = bgr_ptr[3];
         *dest_scan++ = bgr_ptr[4];
         *dest_scan = bgr_ptr[5];
       } else {
         *dest_scan++ = bgr_ptr[0];
         *dest_scan++ = bgr_ptr[1];
         *dest_scan = bgr_ptr[2];
       }
       dest_scan += comps - 2;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_8bppPlt2Rgb(FXDIB_Format dst_format,
                                   uint8_t* dest_buf,
                                   int dest_pitch,
                                   int width,
                                   int height,
                                   const CFX_DIBSource* pSrcBitmap,
                                   int src_left,
-                                  int src_top,
-                                  void* pIccTransform) {
+                                  int src_top) {
   int comps = (dst_format & 0xff) / 8;
   uint32_t* src_plt = pSrcBitmap->GetPalette();
   uint32_t plt[256];
   uint8_t* bgr_ptr = (uint8_t*)plt;
   if (!pSrcBitmap->IsCmykImage()) {
     for (int i = 0; i < 256; i++) {
       *bgr_ptr++ = FXARGB_B(src_plt[i]);
       *bgr_ptr++ = FXARGB_G(src_plt[i]);
       *bgr_ptr++ = FXARGB_R(src_plt[i]);
     }
     bgr_ptr = (uint8_t*)plt;
   }
-  if (pIccTransform) {
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int i = 0; i < 256; i++) {
-        plt[i] = FXCMYK_TODIB(src_plt[i]);
-      }
+
+  if (pSrcBitmap->IsCmykImage()) {
+    for (int i = 0; i < 256; i++) {
+      AdobeCMYK_to_sRGB1(
+          FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
+          FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]), bgr_ptr[2],
+          bgr_ptr[1], bgr_ptr[0]);
+      bgr_ptr += 3;
     }
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    pIccModule->TranslateScanline(pIccTransform, (uint8_t*)plt,
-                                  (const uint8_t*)plt, 256);
-  } else {
-    if (pSrcBitmap->IsCmykImage()) {
-      for (int i = 0; i < 256; i++) {
-        AdobeCMYK_to_sRGB1(
-            FXSYS_GetCValue(src_plt[i]), FXSYS_GetMValue(src_plt[i]),
-            FXSYS_GetYValue(src_plt[i]), FXSYS_GetKValue(src_plt[i]),
-            bgr_ptr[2], bgr_ptr[1], bgr_ptr[0]);
-        bgr_ptr += 3;
-      }
-      bgr_ptr = (uint8_t*)plt;
-    }
+    bgr_ptr = (uint8_t*)plt;
   }
+
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     const uint8_t* src_scan = pSrcBitmap->GetScanline(src_top + row) + src_left;
     for (int col = 0; col < width; col++) {
       uint8_t* src_pixel = bgr_ptr + 3 * (*src_scan++);
       *dest_scan++ = *src_pixel++;
       *dest_scan++ = *src_pixel++;
       *dest_scan = *src_pixel++;
       dest_scan += comps - 2;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_24bppRgb2Rgb24(uint8_t* dest_buf,
                                      int dest_pitch,
                                      int width,
                                      int height,
                                      const CFX_DIBSource* pSrcBitmap,
                                      int src_left,
-                                     int src_top,
-                                     void* pIccTransform) {
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * 3;
-      pIccModule->TranslateScanline(pIccTransform, dest_scan, src_scan, width);
-    }
-  } else {
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * 3;
-      FXSYS_memcpy(dest_scan, src_scan, width * 3);
-    }
+                                     int src_top) {
+  for (int row = 0; row < height; row++) {
+    uint8_t* dest_scan = dest_buf + row * dest_pitch;
+    const uint8_t* src_scan =
+        pSrcBitmap->GetScanline(src_top + row) + src_left * 3;
+    FXSYS_memcpy(dest_scan, src_scan, width * 3);
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_32bppRgb2Rgb24(uint8_t* dest_buf,
                                      int dest_pitch,
                                      int width,
                                      int height,
                                      const CFX_DIBSource* pSrcBitmap,
                                      int src_left,
-                                     int src_top,
-                                     void* pIccTransform) {
+                                     int src_top) {
   for (int row = 0; row < height; row++) {
     uint8_t* dest_scan = dest_buf + row * dest_pitch;
     const uint8_t* src_scan =
         pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
     for (int col = 0; col < width; col++) {
       *dest_scan++ = *src_scan++;
       *dest_scan++ = *src_scan++;
       *dest_scan++ = *src_scan++;
       src_scan++;
     }
   }
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      pIccModule->TranslateScanline(pIccTransform, dest_scan, dest_scan, width);
-    }
-  }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_Rgb2Rgb32(uint8_t* dest_buf,
                                 int dest_pitch,
                                 int width,
                                 int height,
                                 const CFX_DIBSource* pSrcBitmap,
                                 int src_left,
-                                int src_top,
-                                void* pIccTransform) {
+                                int src_top) {
   int comps = pSrcBitmap->GetBPP() / 8;
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * comps;
-      for (int col = 0; col < width; col++) {
-        pIccModule->TranslateScanline(pIccTransform, dest_scan, src_scan, 1);
-        dest_scan += 4;
-        src_scan += comps;
-      }
-    }
-  } else {
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * comps;
-      for (int col = 0; col < width; col++) {
-        *dest_scan++ = *src_scan++;
-        *dest_scan++ = *src_scan++;
-        *dest_scan++ = *src_scan++;
-        dest_scan++;
-        src_scan += comps - 3;
-      }
+  for (int row = 0; row < height; row++) {
+    uint8_t* dest_scan = dest_buf + row * dest_pitch;
+    const uint8_t* src_scan =
+        pSrcBitmap->GetScanline(src_top + row) + src_left * comps;
+    for (int col = 0; col < width; col++) {
+      *dest_scan++ = *src_scan++;
+      *dest_scan++ = *src_scan++;
+      *dest_scan++ = *src_scan++;
+      dest_scan++;
+      src_scan += comps - 3;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer_32bppCmyk2Rgb32(uint8_t* dest_buf,
                                       int dest_pitch,
                                       int width,
                                       int height,
                                       const CFX_DIBSource* pSrcBitmap,
                                       int src_left,
-                                      int src_top,
-                                      void* pIccTransform) {
-  if (pIccTransform) {
-    CCodec_IccModule* pIccModule =
-        CFX_GEModule::Get()->GetCodecModule()->GetIccModule();
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
-      for (int col = 0; col < width; col++) {
-        pIccModule->TranslateScanline(pIccTransform, dest_scan, src_scan, 1);
-        dest_scan += 4;
-        src_scan += 4;
-      }
-    }
-  } else {
-    for (int row = 0; row < height; row++) {
-      uint8_t* dest_scan = dest_buf + row * dest_pitch;
-      const uint8_t* src_scan =
-          pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
-      for (int col = 0; col < width; col++) {
-        AdobeCMYK_to_sRGB1(src_scan[0], src_scan[1], src_scan[2], src_scan[3],
-                           dest_scan[2], dest_scan[1], dest_scan[0]);
-        dest_scan += 4;
-        src_scan += 4;
-      }
+                                      int src_top) {
+  for (int row = 0; row < height; row++) {
+    uint8_t* dest_scan = dest_buf + row * dest_pitch;
+    const uint8_t* src_scan =
+        pSrcBitmap->GetScanline(src_top + row) + src_left * 4;
+    for (int col = 0; col < width; col++) {
+      AdobeCMYK_to_sRGB1(src_scan[0], src_scan[1], src_scan[2], src_scan[3],
+                         dest_scan[2], dest_scan[1], dest_scan[0]);
+      dest_scan += 4;
+      src_scan += 4;
     }
   }
   return TRUE;
 }
+
 FX_BOOL ConvertBuffer(FXDIB_Format dest_format,
                       uint8_t* dest_buf,
                       int dest_pitch,
                       int width,
                       int height,
                       const CFX_DIBSource* pSrcBitmap,
                       int src_left,
                       int src_top,
-                      uint32_t*& d_pal,
-                      void* pIccTransform) {
+                      uint32_t*& d_pal) {
   FXDIB_Format src_format = pSrcBitmap->GetFormat();
-  if (!CFX_GEModule::Get()->GetCodecModule() ||
-      !CFX_GEModule::Get()->GetCodecModule()->GetIccModule()) {
-    pIccTransform = nullptr;
-  }
   switch (dest_format) {
     case FXDIB_Invalid:
     case FXDIB_1bppCmyk:
     case FXDIB_1bppMask:
     case FXDIB_1bppRgb:
       ASSERT(FALSE);
       return FALSE;
     case FXDIB_8bppMask: {
       if ((src_format & 0xff) == 1) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_1bppPlt2Gray(dest_buf, dest_pitch, width, height,
-                                            pSrcBitmap, src_left, src_top,
-                                            pIccTransform);
+                                            pSrcBitmap, src_left, src_top);
         }
         return ConvertBuffer_1bppMask2Gray(dest_buf, dest_pitch, width, height,
                                            pSrcBitmap, src_left, src_top);
       }
       if ((src_format & 0xff) == 8) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_8bppPlt2Gray(dest_buf, dest_pitch, width, height,
-                                            pSrcBitmap, src_left, src_top,
-                                            pIccTransform);
+                                            pSrcBitmap, src_left, src_top);
         }
         return ConvertBuffer_8bppMask2Gray(dest_buf, dest_pitch, width, height,
                                            pSrcBitmap, src_left, src_top);
       }
       if ((src_format & 0xff) >= 24) {
         return ConvertBuffer_RgbOrCmyk2Gray(dest_buf, dest_pitch, width, height,
-                                            pSrcBitmap, src_left, src_top,
-                                            pIccTransform);
+                                            pSrcBitmap, src_left, src_top);
       }
       return FALSE;
     }
     case FXDIB_8bppRgb:
     case FXDIB_8bppRgba: {
       if ((src_format & 0xff) == 8 && !pSrcBitmap->GetPalette()) {
         return ConvertBuffer(FXDIB_8bppMask, dest_buf, dest_pitch, width,
-                             height, pSrcBitmap, src_left, src_top, d_pal,
-                             pIccTransform);
+                             height, pSrcBitmap, src_left, src_top, d_pal);
       }
       d_pal = FX_Alloc(uint32_t, 256);
       if (((src_format & 0xff) == 1 || (src_format & 0xff) == 8) &&
           pSrcBitmap->GetPalette()) {
         return ConvertBuffer_Plt2PltRgb8(dest_buf, dest_pitch, width, height,
-                                         pSrcBitmap, src_left, src_top, d_pal,
-                                         pIccTransform);
+                                         pSrcBitmap, src_left, src_top, d_pal);
       }
       if ((src_format & 0xff) >= 24) {
         return ConvertBuffer_Rgb2PltRgb8(dest_buf, dest_pitch, width, height,
-                                         pSrcBitmap, src_left, src_top, d_pal,
-                                         pIccTransform);
+                                         pSrcBitmap, src_left, src_top, d_pal);
       }
       return FALSE;
     }
     case FXDIB_Rgb:
     case FXDIB_Rgba: {
       if ((src_format & 0xff) == 1) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_1bppPlt2Rgb(dest_format, dest_buf, dest_pitch,
                                            width, height, pSrcBitmap, src_left,
-                                           src_top, pIccTransform);
+                                           src_top);
         }
         return ConvertBuffer_1bppMask2Rgb(dest_format, dest_buf, dest_pitch,
                                           width, height, pSrcBitmap, src_left,
                                           src_top);
       }
       if ((src_format & 0xff) == 8) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_8bppPlt2Rgb(dest_format, dest_buf, dest_pitch,
                                            width, height, pSrcBitmap, src_left,
-                                           src_top, pIccTransform);
+                                           src_top);
         }
         return ConvertBuffer_8bppMask2Rgb(dest_format, dest_buf, dest_pitch,
                                           width, height, pSrcBitmap, src_left,
                                           src_top);
       }
       if ((src_format & 0xff) == 24) {
         return ConvertBuffer_24bppRgb2Rgb24(dest_buf, dest_pitch, width, height,
-                                            pSrcBitmap, src_left, src_top,
-                                            pIccTransform);
+                                            pSrcBitmap, src_left, src_top);
       }
       if ((src_format & 0xff) == 32) {
         return ConvertBuffer_32bppRgb2Rgb24(dest_buf, dest_pitch, width, height,
-                                            pSrcBitmap, src_left, src_top,
-                                            pIccTransform);
+                                            pSrcBitmap, src_left, src_top);
       }
       return FALSE;
     }
     case FXDIB_Argb:
     case FXDIB_Rgb32: {
       if ((src_format & 0xff) == 1) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_1bppPlt2Rgb(dest_format, dest_buf, dest_pitch,
                                            width, height, pSrcBitmap, src_left,
-                                           src_top, pIccTransform);
+                                           src_top);
         }
         return ConvertBuffer_1bppMask2Rgb(dest_format, dest_buf, dest_pitch,
                                           width, height, pSrcBitmap, src_left,
                                           src_top);
       }
       if ((src_format & 0xff) == 8) {
         if (pSrcBitmap->GetPalette()) {
           return ConvertBuffer_8bppPlt2Rgb(dest_format, dest_buf, dest_pitch,
                                            width, height, pSrcBitmap, src_left,
-                                           src_top, pIccTransform);
+                                           src_top);
         }
         return ConvertBuffer_8bppMask2Rgb(dest_format, dest_buf, dest_pitch,
                                           width, height, pSrcBitmap, src_left,
                                           src_top);
       }
       if ((src_format & 0xff) >= 24) {
         if (src_format & 0x0400) {
           return ConvertBuffer_32bppCmyk2Rgb32(dest_buf, dest_pitch, width,
                                                height, pSrcBitmap, src_left,
-                                               src_top, pIccTransform);
+                                               src_top);
         }
         return ConvertBuffer_Rgb2Rgb32(dest_buf, dest_pitch, width, height,
-                                       pSrcBitmap, src_left, src_top,
-                                       pIccTransform);
+                                       pSrcBitmap, src_left, src_top);
       }
       return FALSE;
     }
     default:
       return FALSE;
   }
 }
-CFX_DIBitmap* CFX_DIBSource::CloneConvert(FXDIB_Format dest_format,
-                                          const FX_RECT* pClip,
-                                          void* pIccTransform) const {
-  if (dest_format == GetFormat() && !pIccTransform) {
-    return Clone(pClip);
-  }
-  if (pClip) {
-    CFX_DIBitmap* pClone = Clone(pClip);
-    if (!pClone) {
-      return nullptr;
-    }
-    if (!pClone->ConvertFormat(dest_format, pIccTransform)) {
-      delete pClone;
-      return nullptr;
-    }
-    return pClone;
-  }
-  CFX_DIBitmap* pClone = new CFX_DIBitmap;
-  if (!pClone->Create(m_Width, m_Height, dest_format)) {
-    delete pClone;
+
+CFX_DIBitmap* CFX_DIBSource::CloneConvert(FXDIB_Format dest_format) const {
+  if (dest_format == GetFormat())
+    return Clone(nullptr);
+
+  std::unique_ptr<CFX_DIBitmap> pClone(new CFX_DIBitmap);
+  if (!pClone->Create(m_Width, m_Height, dest_format))
     return nullptr;
-  }
-  FX_BOOL ret = TRUE;
+
   CFX_DIBitmap* pSrcAlpha = nullptr;
   if (HasAlpha()) {
     pSrcAlpha = (GetFormat() == FXDIB_Argb) ? GetAlphaMask() : m_pAlphaMask;
-    if (!pSrcAlpha) {
-      delete pClone;
+    if (!pSrcAlpha)
       return nullptr;
-    }
   }
+
+  FX_BOOL ret = TRUE;
   if (dest_format & 0x0200) {
     if (dest_format == FXDIB_Argb) {
       ret = pSrcAlpha ? pClone->LoadChannel(FXDIB_Alpha, pSrcAlpha, FXDIB_Alpha)
                       : pClone->LoadChannel(FXDIB_Alpha, 0xff);
     } else {
       ret = pClone->CopyAlphaMask(pSrcAlpha);
     }
   }
   if (pSrcAlpha && pSrcAlpha != m_pAlphaMask) {
     delete pSrcAlpha;
     pSrcAlpha = nullptr;
   }
-  if (!ret) {
-    delete pClone;
+  if (!ret)
     return nullptr;
-  }
+
   uint32_t* pal_8bpp = nullptr;
-  ret = ConvertBuffer(dest_format, pClone->GetBuffer(), pClone->GetPitch(),
-                      m_Width, m_Height, this, 0, 0, pal_8bpp, pIccTransform);
-  if (!ret) {
+  if (!ConvertBuffer(dest_format, pClone->GetBuffer(), pClone->GetPitch(),
+                     m_Width, m_Height, this, 0, 0, pal_8bpp)) {
     FX_Free(pal_8bpp);
-    delete pClone;
     return nullptr;
   }
   if (pal_8bpp) {
     pClone->CopyPalette(pal_8bpp);
     FX_Free(pal_8bpp);
-    pal_8bpp = nullptr;
   }
-  return pClone;
+  return pClone.release();
 }
-FX_BOOL CFX_DIBitmap::ConvertFormat(FXDIB_Format dest_format,
-                                    void* pIccTransform) {
+
+FX_BOOL CFX_DIBitmap::ConvertFormat(FXDIB_Format dest_format) {
   FXDIB_Format src_format = GetFormat();
-  if (dest_format == src_format && !pIccTransform) {
+  if (dest_format == src_format)
     return TRUE;
-  }
+
   if (dest_format == FXDIB_8bppMask && src_format == FXDIB_8bppRgb &&
       !m_pPalette) {
     m_AlphaFlag = 1;
     return TRUE;
   }
-  if (dest_format == FXDIB_Argb && src_format == FXDIB_Rgb32 &&
-      !pIccTransform) {
+  if (dest_format == FXDIB_Argb && src_format == FXDIB_Rgb32) {
     m_AlphaFlag = 2;
     for (int row = 0; row < m_Height; row++) {
       uint8_t* scanline = m_pBuffer + row * m_Pitch + 3;
       for (int col = 0; col < m_Width; col++) {
         *scanline = 0xff;
         scanline += 4;
       }
     }
     return TRUE;
   }
@@ skipping 32 matching lines @@
         pAlphaMask = m_pAlphaMask;
         m_pAlphaMask = nullptr;
       } else {
         pAlphaMask = m_pAlphaMask;
       }
     }
   }
   FX_BOOL ret = FALSE;
   uint32_t* pal_8bpp = nullptr;
   ret = ConvertBuffer(dest_format, dest_buf, dest_pitch, m_Width, m_Height,
-                      this, 0, 0, pal_8bpp, pIccTransform);
+                      this, 0, 0, pal_8bpp);
   if (!ret) {
     FX_Free(pal_8bpp);
     if (pAlphaMask != m_pAlphaMask) {
       delete pAlphaMask;
     }
     FX_Free(dest_buf);
     return FALSE;
   }
   if (m_pAlphaMask && pAlphaMask != m_pAlphaMask) {
     delete m_pAlphaMask;
   }
   m_pAlphaMask = pAlphaMask;
   FX_Free(m_pPalette);
   m_pPalette = pal_8bpp;
   if (!m_bExtBuf) {
     FX_Free(m_pBuffer);
   }
   m_bExtBuf = FALSE;
   m_pBuffer = dest_buf;
   m_bpp = (uint8_t)dest_format;
   m_AlphaFlag = (uint8_t)(dest_format >> 8);
   m_Pitch = dest_pitch;
   return TRUE;
 }