Fix Skia GN build on Mac

Fix Skia GN build on Mac

The build has been broken. This should make it compilable.

Committed: https://pdfium.googlesource.com/pdfium/+/ca0bc7deead753698af70dced5e619176e37c65a

[Wei Li, 2016-06-18 04:21:09]

weili@chromium.org changed reviewers:
+ caryclark@google.com, thestig@chromium.org

[Wei Li, 2016-06-18 04:21:10]

pls review, thanks

[Wei Li, 2016-06-18 04:21:29]

Description was changed from

==========
Fix Skia build on Mac

The build has been broken. This should make it compilable.
==========

to

==========
Fix Skia GN build on Mac

The build has been broken. This should make it compilable.
==========

[dsinclair, 2016-06-18 13:28:52]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-18 13:28:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075343002/1

[commit-bot: I haz the power, 2016-06-18 13:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 13:29:06]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-06-18 13:29:22]

Sending this to a CQ dry run which should trigger the experimental bots without
committing.

[dsinclair, 2016-06-18 13:31:33]

hm, or not. As far as I understand, it should ....

[Wei Li, 2016-06-18 22:00:54]

On 2016/06/18 13:31:33, dsinclair wrote:
> hm, or not. As far as I understand, it should ....

I manually triggered the skia bots. I can see the results on this page in
"Trybot results"
section. If you can not, here are the results:

mac:
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_skia/builds/89
win:
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_skia/builds/84
linux:
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_skia/buil...

[dsinclair, 2016-06-21 19:49:02]

https://codereview.chromium.org/2075343002/diff/1/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/2075343002/diff/1/skia/BUILD.gn#newcode342
skia/BUILD.gn:342:
"//third_party/skia/src/ports/SkFontMgr_custom_empty_factory.cpp",
Cary, is this OK? I know you removed these from a different part of the build a
while ago, is this the correct place for them?

[dsinclair, 2016-06-22 14:02:20]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-22 14:02:20]

lgtm

Let's get this in so the bots are all green and we can figure out if there are
other bits to fix later.

[commit-bot: I haz the power, 2016-06-22 14:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075343002/1

[commit-bot: I haz the power, 2016-06-22 14:24:23]

Description was changed from

==========
Fix Skia GN build on Mac

The build has been broken. This should make it compilable.
==========

to

==========
Fix Skia GN build on Mac

The build has been broken. This should make it compilable.

Committed:
https://pdfium.googlesource.com/pdfium/+/ca0bc7deead753698af70dced5e619176e37...
==========

[commit-bot: I haz the power, 2016-06-22 14:24:24]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ca0bc7deead753698af70dced5e619176e37...