Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 207523004: Always use global indexes for nodes and edges in the heap snapshot representation (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Always use global indexes for nodes and edges in the heap snapshot representation - HeapSnapshotNode, HeapSnapshotEdge and HeapSnapshotRetainerEdge now store only reference to HeapSnapshot and global index of corresponding item. - all index boundaries were moved out of these classes into corresponding iterators BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169732

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -80 lines) Patch
M LayoutTests/inspector/profiler/heap-snapshot.html View 1 2 chunks +8 lines, -16 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshot.js View 1 15 chunks +46 lines, -49 lines 0 comments Download
M Source/devtools/front_end/JSHeapSnapshot.js View 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yurys
6 years, 9 months ago (2014-03-21 08:17:04 UTC) #1
alph
lgtm https://codereview.chromium.org/207523004/diff/1/LayoutTests/inspector/profiler/heap-snapshot.html File LayoutTests/inspector/profiler/heap-snapshot.html (right): https://codereview.chromium.org/207523004/diff/1/LayoutTests/inspector/profiler/heap-snapshot.html#newcode69 LayoutTests/inspector/profiler/heap-snapshot.html:69: for (; edgeIterator.hasNext(); edgeIterator.next()) { s/[{}]// https://codereview.chromium.org/207523004/diff/1/Source/devtools/front_end/HeapSnapshot.js File ...
6 years, 9 months ago (2014-03-21 08:30:39 UTC) #2
yurys
https://codereview.chromium.org/207523004/diff/1/LayoutTests/inspector/profiler/heap-snapshot.html File LayoutTests/inspector/profiler/heap-snapshot.html (right): https://codereview.chromium.org/207523004/diff/1/LayoutTests/inspector/profiler/heap-snapshot.html#newcode69 LayoutTests/inspector/profiler/heap-snapshot.html:69: for (; edgeIterator.hasNext(); edgeIterator.next()) { On 2014/03/21 08:30:39, alph ...
6 years, 9 months ago (2014-03-21 08:33:20 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 08:33:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/207523004/20001
6 years, 9 months ago (2014-03-21 08:33:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 09:15:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 09:15:28 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-21 09:32:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/207523004/20001
6 years, 9 months ago (2014-03-21 09:32:37 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 10:09:30 UTC) #10
Message was sent while issue was closed.
Change committed as 169732

Powered by Google App Engine
This is Rietveld 408576698