Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: Source/devtools/front_end/JSHeapSnapshot.js

Issue 207523004: Always use global indexes for nodes and edges in the heap snapshot representation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/HeapSnapshot.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/JSHeapSnapshot.js
diff --git a/Source/devtools/front_end/JSHeapSnapshot.js b/Source/devtools/front_end/JSHeapSnapshot.js
index f1af0f2436e066953c00acd003eefeb761cf3ed5..eb6ec978ffdff38fbde91220a3f478c4f2750fe6 100644
--- a/Source/devtools/front_end/JSHeapSnapshot.js
+++ b/Source/devtools/front_end/JSHeapSnapshot.js
@@ -58,23 +58,23 @@ WebInspector.JSHeapSnapshot.prototype = {
},
/**
- * @param {!Uint32Array} edges
+ * @override
* @param {number} edgeIndex
* @return {!WebInspector.JSHeapSnapshotEdge}
*/
- createEdge: function(edges, edgeIndex)
+ createEdge: function(edgeIndex)
{
- return new WebInspector.JSHeapSnapshotEdge(this, edges, edgeIndex);
+ return new WebInspector.JSHeapSnapshotEdge(this, edgeIndex);
},
/**
- * @param {number} retainedNodeIndex
+ * @override
* @param {number} retainerIndex
* @return {!WebInspector.JSHeapSnapshotRetainerEdge}
*/
- createRetainingEdge: function(retainedNodeIndex, retainerIndex)
+ createRetainingEdge: function(retainerIndex)
{
- return new WebInspector.JSHeapSnapshotRetainerEdge(this, retainedNodeIndex, retainerIndex);
+ return new WebInspector.JSHeapSnapshotRetainerEdge(this, retainerIndex);
},
/**
@@ -639,12 +639,11 @@ WebInspector.JSHeapSnapshotNode.prototype = {
* @constructor
* @extends {WebInspector.HeapSnapshotEdge}
* @param {!WebInspector.JSHeapSnapshot} snapshot
- * @param {!Uint32Array} edges
* @param {number=} edgeIndex
*/
-WebInspector.JSHeapSnapshotEdge = function(snapshot, edges, edgeIndex)
+WebInspector.JSHeapSnapshotEdge = function(snapshot, edgeIndex)
{
- WebInspector.HeapSnapshotEdge.call(this, snapshot, edges, edgeIndex);
+ WebInspector.HeapSnapshotEdge.call(this, snapshot, edgeIndex);
}
WebInspector.JSHeapSnapshotEdge.prototype = {
@@ -654,7 +653,7 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
clone: function()
{
var snapshot = /** @type {!WebInspector.JSHeapSnapshot} */ (this._snapshot);
- return new WebInspector.JSHeapSnapshotEdge(snapshot, this._edges, this.edgeIndex);
+ return new WebInspector.JSHeapSnapshotEdge(snapshot, this.edgeIndex);
},
/**
@@ -779,10 +778,11 @@ WebInspector.JSHeapSnapshotEdge.prototype = {
* @constructor
* @extends {WebInspector.HeapSnapshotRetainerEdge}
* @param {!WebInspector.JSHeapSnapshot} snapshot
+ * @param {number} retainerIndex
*/
-WebInspector.JSHeapSnapshotRetainerEdge = function(snapshot, retainedNodeIndex, retainerIndex)
+WebInspector.JSHeapSnapshotRetainerEdge = function(snapshot, retainerIndex)
{
- WebInspector.HeapSnapshotRetainerEdge.call(this, snapshot, retainedNodeIndex, retainerIndex);
+ WebInspector.HeapSnapshotRetainerEdge.call(this, snapshot, retainerIndex);
}
WebInspector.JSHeapSnapshotRetainerEdge.prototype = {
@@ -791,7 +791,8 @@ WebInspector.JSHeapSnapshotRetainerEdge.prototype = {
*/
clone: function()
{
- return new WebInspector.JSHeapSnapshotRetainerEdge(this._snapshot, this._retainedNodeIndex, this.retainerIndex());
+ var snapshot = /** @type {!WebInspector.JSHeapSnapshot} */ (this._snapshot);
+ return new WebInspector.JSHeapSnapshotRetainerEdge(snapshot, this.retainerIndex());
},
/**
« no previous file with comments | « Source/devtools/front_end/HeapSnapshot.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698