Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: appengine/findit/crash/test/fracas_test.py

Issue 2075153003: [Findit] Add fracas analysis result feedback page. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/fracas_test.py
diff --git a/appengine/findit/crash/test/fracas_test.py b/appengine/findit/crash/test/fracas_test.py
index a9e6ad65c9798505355718d4ba1afeb2a0d91bf1..be8e5f4b5f9c2daa906cc1f085e609803555cab9 100644
--- a/appengine/findit/crash/test/fracas_test.py
+++ b/appengine/findit/crash/test/fracas_test.py
@@ -58,10 +58,11 @@ class FracasTest(CrashTestCase):
def _MockGetDEPSRollsDict(*_):
return {'src/': DependencyRoll('src/', 'https://repo', '1', '2')}
+ dummy_match_result = MatchResult(self.GetDummyChangeLog(), 'src/')
def _MockFindItForCrash(*args):
regression_deps_rolls = args[1]
if regression_deps_rolls:
- return ['DummyResultObject']
+ return [dummy_match_result]
return []
@@ -90,10 +91,10 @@ class FracasTest(CrashTestCase):
expected_results = {
'found': True,
+ 'regression_range': ('50.0.1233.0', '50.0.1234.0'),
'suspected_project': '',
'suspected_components': [],
- 'suspected_cls': ['DummyResultObject'],
- 'regression_range': ('50.0.1233.0', '50.0.1234.0')
+ 'suspected_cls': [dummy_match_result.ToDict()],
}
expected_tag = {
'found_suspects': True,
@@ -110,10 +111,10 @@ class FracasTest(CrashTestCase):
expected_results = {
'found': False,
+ 'regression_range': None,
'suspected_project': '',
'suspected_components': [],
'suspected_cls': [],
- 'regression_range': None
}
expected_tag = {
'found_suspects': False,

Powered by Google App Engine
This is Rietveld 408576698