Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issue 20751008: Text decorations should be listed as non-inheritable (Closed)

Created:
7 years, 4 months ago by abinader
Modified:
7 years, 4 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, Savago-old
Visibility:
Public.

Description

Text decorations should be listed as non-inheritable Both "text-decoration" specs (CSS 2.1, CSS 3) and "text-decoration-line spec (CSS 3) states these properties are not inherited (w/ exceptions, which are currently handled by -in-effect property), however those were listed as inherited for no reason - thus preserving behavior as shown by layout test results. BUG=165462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155560

Patch Set 1 #

Patch Set 2 : Added extra layout test cases to ensure these properties are not inherited implicitly. #

Patch Set 3 : Fixed typo in getComputedStyle-text-decoration.js #

Messages

Total messages: 7 (0 generated)
abinader
The failing tests are not related to this patch (as stated by mac_blink_rel results).
7 years, 4 months ago (2013-08-02 00:53:42 UTC) #1
Julien - ping for review
Is this tested anywhere? If it's not tested, it should be.
7 years, 4 months ago (2013-08-02 22:55:14 UTC) #2
abinader
On 2013/08/02 22:55:14, Julien Chaffraix wrote: > Is this tested anywhere? If it's not tested, ...
7 years, 4 months ago (2013-08-05 20:05:52 UTC) #3
Julien - ping for review
lgtm
7 years, 4 months ago (2013-08-05 22:07:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/20751008/17001
7 years, 4 months ago (2013-08-05 22:08:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruno.d@partner.samsung.com/20751008/28001
7 years, 4 months ago (2013-08-05 23:03:53 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 01:25:13 UTC) #7
Message was sent while issue was closed.
Change committed as 155560

Powered by Google App Engine
This is Rietveld 408576698