Separate Remote InterfaceProvider again, and add a new client lib type for it.

Separate Remote InterfaceProvider again, and add a new client lib type for it.

Also adds some more useful methods to InterfaceRegistry to aid in the replacement of ServiceRegistry.

R=rockot@chromium.org

Committed: https://crrev.com/eb53aa6a11cacd4ec9ae7a572ba674cfb56a525f
Cr-Commit-Position: refs/heads/master@{#400563}

[Ken Rockot(use gerrit already), 2016-06-16 23:48:58]

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
File services/shell/public/cpp/connection.h (right):

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
services/shell/public/cpp/connection.h:145: // InterfaceProviders between this
application and the remote.
nit: update comment

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
File services/shell/public/cpp/interface_registry.h (right):

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
services/shell/public/cpp/interface_registry.h:73: mojom::InterfaceProviderPtr
TakeClientHandle();
Given that you're adding a Bind method, let's get rid of client_handle_ and this
method.

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
services/shell/public/cpp/interface_registry.h:75: void
Bind(mojom::InterfaceProviderRequest local_interfaces_request);
nit: Document this, specifically worth noting that this replaces the binding
that was established by the constructor, if any. Or maybe it should just DCHECK
and only be usable if the constructor didn't bind. Your call.

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
File services/shell/public/cpp/remote_interface_registry.h (right):

https://codereview.chromium.org/2075003002/diff/20001/services/shell/public/c...
services/shell/public/cpp/remote_interface_registry.h:12: class
RemoteInterfaceRegistry {
nit: Documentation. It's worth calling out that this is an InterfaceProviderPtr
with the ability to override outgoing connections for testing.

[Ben Goodger (Google), 2016-06-17 03:41:46]

Updated PTAL

[Ken Rockot(use gerrit already), 2016-06-17 15:59:55]

conceptually lgtm but you got red

[Ben Goodger (Google), 2016-06-17 19:23:45]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-06-17 19:23:45]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2075003002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-06-17 19:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075003002/80001

[commit-bot: I haz the power, 2016-06-17 19:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 19:41:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-06-17 21:04:44]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-06-17 21:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2075003002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-06-17 21:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2075003002/100001

[commit-bot: I haz the power, 2016-06-18 01:21:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-18 01:23:28]

Description was changed from

==========
Separate Remote InterfaceProvider again, and add a new client lib type for it.

Also adds some more useful methods to InterfaceRegistry to aid in the
replacement of ServiceRegistry.

R=rockot@chromium.org
==========

to

==========
Separate Remote InterfaceProvider again, and add a new client lib type for it.

Also adds some more useful methods to InterfaceRegistry to aid in the
replacement of ServiceRegistry.

R=rockot@chromium.org

Committed: https://crrev.com/eb53aa6a11cacd4ec9ae7a572ba674cfb56a525f
Cr-Commit-Position: refs/heads/master@{#400563}
==========

[commit-bot: I haz the power, 2016-06-18 01:23:29]

Patchset 6 (id:??) landed as
https://crrev.com/eb53aa6a11cacd4ec9ae7a572ba674cfb56a525f
Cr-Commit-Position: refs/heads/master@{#400563}