Change RenderFrame to use InterfaceRegistry et al.

Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/155ecf8e0b1a9b9a0d9e478d37b5f54c0db35917
Cr-Commit-Position: refs/heads/master@{#401130}

[Ben Goodger (Google), 2016-06-17 23:27:09]

Description was changed from

==========
Change RenderFrame to use InterfaceRegistry et al.

BUG=
==========

to

==========
Change RenderFrame to use InterfaceRegistry et al.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-06-21 15:42:52]

Description was changed from

==========
Change RenderFrame to use InterfaceRegistry et al.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Ben Goodger (Google), 2016-06-21 15:42:53]

ben@chromium.org changed reviewers:
+ rockot@chromium.org

[Ben Goodger (Google), 2016-06-21 15:44:10]

I'm down to my last couple of failures so I think this is ready for review.

Main things to look at are render_frame_host_impl, render_frame_impl,
render_thread_impl, child_thread_impl and  services/shell/public/cpp

There are a lot of things yet to be covered but this CL is already huge enough.

[Ken Rockot(use gerrit already), 2016-06-21 16:16:23]

https://codereview.chromium.org/2079943002/diff/440001/content/browser/frame_...
File content/browser/frame_host/frame_mojo_shell.cc (right):

https://codereview.chromium.org/2079943002/diff/440001/content/browser/frame_...
content/browser/frame_host/frame_mojo_shell.cc:72: // TODO(beng): find
connection.
What does this mean?

https://codereview.chromium.org/2079943002/diff/440001/content/browser/frame_...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2079943002/diff/440001/content/browser/frame_...
content/browser/frame_host/render_frame_host_impl.cc:2395: // TODO(beng):
connection.
What does this mean?

https://codereview.chromium.org/2079943002/diff/440001/content/child/mojo/moj...
File content/child/mojo/mojo_application.cc (right):

https://codereview.chromium.org/2079943002/diff/440001/content/child/mojo/moj...
content/child/mojo/mojo_application.cc:31: // TODO(beng): null Connection.
What does this mean?

https://codereview.chromium.org/2079943002/diff/440001/services/shell/public/...
File services/shell/public/cpp/lib/interface_provider.cc (right):

https://codereview.chromium.org/2079943002/diff/440001/services/shell/public/...
services/shell/public/cpp/lib/interface_provider.cc:9:
InterfaceProvider::InterfaceProvider(
nit: bad indentation

https://codereview.chromium.org/2079943002/diff/440001/services/shell/public/...
services/shell/public/cpp/lib/interface_provider.cc:13:
InterfaceProvider::~InterfaceProvider() {}
nit: bad indentation

[Ben Goodger (Google), 2016-06-21 19:52:50]

Updated PTAL.

[Ben Goodger (Google), 2016-06-21 19:54:19]

On 2016/06/21 19:52:50, Ben Goodger (Google) wrote:
> Updated PTAL.

Check out content/browser/android/service_registry_android_impl.cc now.

[Ken Rockot(use gerrit already), 2016-06-21 20:13:19]

lgtm

[Ben Goodger (Google), 2016-06-21 20:37:09]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-06-21 20:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079943002/540001

[Ben Goodger (Google), 2016-06-21 20:43:55]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-06-21 20:43:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2079943002/#ps560001
(title: ".")

[commit-bot: I haz the power, 2016-06-21 20:44:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079943002/560001

[commit-bot: I haz the power, 2016-06-21 22:44:05]

Description was changed from

==========
Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-06-21 22:44:07]

Committed patchset #30 (id:560001)

[commit-bot: I haz the power, 2016-06-21 22:47:04]

Description was changed from

==========
Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change RenderFrame to use InterfaceRegistry et al.

R=rockot@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/155ecf8e0b1a9b9a0d9e478d37b5f54c0db35917
Cr-Commit-Position: refs/heads/master@{#401130}
==========

[commit-bot: I haz the power, 2016-06-21 22:47:06]

Patchset 30 (id:??) landed as
https://crrev.com/155ecf8e0b1a9b9a0d9e478d37b5f54c0db35917
Cr-Commit-Position: refs/heads/master@{#401130}