Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2074933006: Mac: Disable visual effects when fullscreen (Closed)

Created:
4 years, 6 months ago by ccameron
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Mac: Disable visual effects when fullscreen These effects result in substantially higher power consumption. Make the change in didEnter/willExit (as opposed to adjustUIForExiting/ ExitingFullscreen) because we want the effect to go away only while the window is fullscreen (not during the transition). BUG=620433 Review-Url: https://codereview.chromium.org/2071973002 Cr-Commit-Position: refs/heads/master@{#400308} (cherry picked from commit 208098685cf35d3bb995cb365d204f0a65381ad3) Committed: https://chromium.googlesource.com/chromium/src/+/78e7db6652e8a9ffd977d97314d393cb180ed4d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
4 years, 6 months ago (2016-06-17 23:58:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78e7db6652e8a9ffd977d97314d393cb180ed4d0.

Powered by Google App Engine
This is Rietveld 408576698