Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2071973002: Mac: Disable visual effects when fullscreen (Closed)

Created:
4 years, 6 months ago by ccameron
Modified:
4 years, 6 months ago
Reviewers:
shrike
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Disable visual effects when fullscreen These effects result in substantially higher power consumption. Make the change in didEnter/willExit (as opposed to adjustUIForExiting/ ExitingFullscreen) because we want the effect to go away only while the window is fullscreen (not during the transition). BUG=620433 Committed: https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3 Cr-Commit-Position: refs/heads/master@{#400308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_view.mm View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ccameron
LMK if this has a reasonable structure -- this is not an are of the ...
4 years, 6 months ago (2016-06-16 21:11:14 UTC) #2
shrike
lgtm
4 years, 6 months ago (2016-06-16 22:43:46 UTC) #3
ccameron
Thanks!
4 years, 6 months ago (2016-06-16 22:45:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071973002/1
4 years, 6 months ago (2016-06-16 22:46:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 00:09:04 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:11:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/208098685cf35d3bb995cb365d204f0a65381ad3
Cr-Commit-Position: refs/heads/master@{#400308}

Powered by Google App Engine
This is Rietveld 408576698