Convert track-cues* and track-delete* tests to testharness.js

Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/876041c17f17d7dc403cce63b394a8bc8b277313
Cr-Commit-Position: refs/heads/master@{#400612}

[Srirama, 2016-06-18 06:43:26]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[Srirama, 2016-06-18 06:46:04]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-06-18 06:46:34]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-18 06:46:35]

PTAL

[fs, 2016-06-18 14:42:09]

First test LG-TM (w/ some additional suggestions). The second one is really
difficult to make something of I'm afraid...

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html
(right):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:31:
var eventObj = {};
Could make the dispatchedEvents list contain only timestamps (without wrapping
an object around them like this), and then maybe rename the list accordingly.

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:45:
assert_less_than_equal(time, dispatchedEvents[i].time);
Maybe add "timestamp/event " + i as the third argument (==description) here.

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html
(left):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:53:
<command><aside><kbd><video oncanplaythrough="canplaythrough()" >
This test has a lot of weird-looking stuff in it, so it's hard to say what's
really relevant and not. Could you look at the commit that added it to try and
determine what was going wrong?

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html
(right):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:27:
setTimeout(function() { t.done(); }, 100);
It looks like one setTimeout might be enough (presumably the one below), but see
below...

[Srirama, 2016-06-18 16:46:57]

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html
(right):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:31:
var eventObj = {};
On 2016/06/18 14:42:09, fs wrote:
> Could make the dispatchedEvents list contain only timestamps (without wrapping
> an object around them like this), and then maybe rename the list accordingly.

Done.

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:45:
assert_less_than_equal(time, dispatchedEvents[i].time);
On 2016/06/18 14:42:09, fs wrote:
> Maybe add "timestamp/event " + i as the third argument (==description) here.

Done.

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html
(left):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:53:
<command><aside><kbd><video oncanplaythrough="canplaythrough()" >
On 2016/06/18 14:42:09, fs wrote:
> This test has a lot of weird-looking stuff in it, so it's hard to say what's
> really relevant and not. Could you look at the commit that added it to try and
> determine what was going wrong?

Didn't have permission to see https://bugs.webkit.org/show_bug.cgi?id=75192. I
feel these are not required by looking at the commit msg "Notify the media
element when tracks are added to and removed from a document instead of a tree
because we don't want to trigger loading unless a track element is in the
document", or do you see anything significant from this msg?

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html
(right):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:27:
setTimeout(function() { t.done(); }, 100);
On 2016/06/18 14:42:09, fs wrote:
> It looks like one setTimeout might be enough (presumably the one below), but
see
> below...

Done.

[fs, 2016-06-18 17:38:13]

lgtm

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html
(left):

https://codereview.chromium.org/2074913006/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html:53:
<command><aside><kbd><video oncanplaythrough="canplaythrough()" >
On 2016/06/18 at 16:46:57, Srirama wrote:
> On 2016/06/18 14:42:09, fs wrote:
> > This test has a lot of weird-looking stuff in it, so it's hard to say what's
> > really relevant and not. Could you look at the commit that added it to try
and
> > determine what was going wrong?
> 
> Didn't have permission to see https://bugs.webkit.org/show_bug.cgi?id=75192. I
feel these are not required by looking at the commit msg "Notify the media
element when tracks are added to and removed from a document instead of a tree
because we don't want to trigger loading unless a track element is in the
document", or do you see anything significant from this msg?

Yes, it doesn't sound like all the "stray" elements are relevant.

https://codereview.chromium.org/2074913006/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html
(right):

https://codereview.chromium.org/2074913006/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:41:
assert_less_than_equal(time, cueTimings[i], "cueTimings[i] " + i);
Nit: Maybe "cueTimings[" + i + "]"

[Srirama, 2016-06-19 04:33:29]

https://codereview.chromium.org/2074913006/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html
(right):

https://codereview.chromium.org/2074913006/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html:41:
assert_less_than_equal(time, cueTimings[i], "cueTimings[i] " + i);
On 2016/06/18 17:38:12, fs wrote:
> Nit: Maybe "cueTimings[" + i + "]"

Done.

[Srirama, 2016-06-19 04:33:41]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-19 04:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2074913006/#ps60001
(title: "address nit")

[commit-bot: I haz the power, 2016-06-19 04:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2074913006/60001

[commit-bot: I haz the power, 2016-06-19 05:44:27]

Description was changed from

==========
Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-19 05:44:27]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-19 05:45:46]

Description was changed from

==========
Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js. 
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert track-cues* and track-delete* tests to testharness.js

Cleaning up track-cues* and track-delete* tests in
media/track to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/876041c17f17d7dc403cce63b394a8bc8b277313
Cr-Commit-Position: refs/heads/master@{#400612}
==========

[commit-bot: I haz the power, 2016-06-19 05:45:47]

Patchset 3 (id:??) landed as
https://crrev.com/876041c17f17d7dc403cce63b394a8bc8b277313
Cr-Commit-Position: refs/heads/master@{#400612}