third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html - Issue 2074913006: Convert track-cues* and track-delete* tests to testharness.js

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-delete-during-setup.html

Issue 2074913006: Convert track-cues* and track-delete* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch.html ('K') | « third_party/WebKit/LayoutTests/media/track/track-cues-sorted-before-dispatch-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-delete-during-setup-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 >	1 <!DOCTYPE html>

	2 <title>Tests track deletion during setup.</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../media-file.js"></script>

	6 <script>

	7 // This should not be necessary, but due to crbug.com/372245 style

	8 // gets dirtied during layout in LayoutTextTrackContainer which

	9 // causes assertions to fail when Document::scrollingElement is

	10 // queried during compositing update (a valid request).

	11 internals.settings.setCompositorWorkerEnabled(false);

	12 </script>

	13 <video>

	14 <track src="captions-webvtt/metadata.vtt">

	15 </video>

	16 <script>

	17 async_test(function(t) {

	18 var video = document.querySelector("video");

	19 var track = document.querySelector("track");

2	20

3 <script>	21 setTimeout(function() {

4 if (window.internals)	22 video.parentNode.removeChild(video);

5 {	23 }, 61);

6 // This should not be necessary, but due to crbug.com/372245 sty le

7 // gets dirtied during layout in LayoutTextTrackContainer which

8 // causes assertions to fail when Document::scrollingElement is

9 // queried during compositing update (a valid request).

10 window.internals.settings.setCompositorWorkerEnabled(false);

11 }

12 </script>

13 <script src=../media-file.js></script>

14 <script></script>

15 <script></script>

16 <script>setTimeout("try { var v = document.querySelector('video'); v.parentNode. removeChild(v); } catch(e) {}", 61);</script>

17 <meta>

18 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

19 (Please avoid writing new tests using video-test.js) -->

20 <script src=../video-test.js></script>

21 <script>

22	24

23 {	25 video.oncanplaythrough = t.step_func(function() {

24 }	26 track.track.mode = "hidden";

	27 setTimeout(function() { t.done(); }, 100);
	fs 2016/06/18 14:42:09 It looks like one setTimeout might be enough (pres It looks like one setTimeout might be enough (presumably the one below), but see below... Srirama 2016/06/18 16:46:57 Done. Show quoted text On 2016/06/18 14:42:09, fs wrote: > It looks like one setTimeout might be enough (presumably the one below), but see > below... Done.
	28 });

25	29

26 function metadataTrackLoaded()	30 track.onload = t.step_func(function() {

27 {	31 var track2 = document.createElement("track");

28 track2 = document.createElement('track');	32 video.appendChild(track2);

29 video.appendChild(track2);	33 setTimeout(function() { t.done(); }, 100);

30 setTimeout("endTest()", 100);	34 });

31 }

32	35

33 function canplaythrough()	36 assert_equals(track.readyState, HTMLTrackElement.NONE);

34 {	37 assert_equals(track.track.mode, "disabled");

35 track1.track.mode = "hidden";

36 setTimeout("endTest()", 100);

37 }

38	38

39 function start()	39 video.src = findMediaFile("video", "../content/test");

40 {	40 });

41 consoleWrite("<feOffset>");	41 </script>

42 findMediaElement();

43

44 track1 = document.querySelectorAll('track')[0];

45 testExpected("track1.readyState", HTMLTrackElement.NONE);

46 testExpected("track1.track.mode", "disabled");

47

48 video.src = findMediaFile("video", "../content/test");

49 consoleWrite("");

50 }

51 </script>

52 <body onload="start()">

53 <command><aside><kbd><video oncanplaythrough="canplaythrough()" >
fs 2016/06/18 14:42:09 This test has a lot of weird-looking stuff in it, This test has a lot of weird-looking stuff in it, so it's hard to say what's really relevant and not. Could you look at the commit that added it to try and determine what was going wrong? Srirama 2016/06/18 16:46:57 Didn't have permission to see https://bugs.webkit. Show quoted text On 2016/06/18 14:42:09, fs wrote: > This test has a lot of weird-looking stuff in it, so it's hard to say what's > really relevant and not. Could you look at the commit that added it to try and > determine what was going wrong? Didn't have permission to see https://bugs.webkit.org/show_bug.cgi?id=75192. I feel these are not required by looking at the commit msg "Notify the media element when tracks are added to and removed from a document instead of a tree because we don't want to trigger loading unless a track element is in the document", or do you see anything significant from this msg? fs 2016/06/18 17:38:12 Yes, it doesn't sound like all the "stray" element Show quoted text On 2016/06/18 at 16:46:57, Srirama wrote: > On 2016/06/18 14:42:09, fs wrote: > > This test has a lot of weird-looking stuff in it, so it's hard to say what's > > really relevant and not. Could you look at the commit that added it to try and > > determine what was going wrong? > > Didn't have permission to see https://bugs.webkit.org/show_bug.cgi?id=75192. I feel these are not required by looking at the commit msg "Notify the media element when tracks are added to and removed from a document instead of a tree because we don't want to trigger loading unless a track element is in the document", or do you see anything significant from this msg? Yes, it doesn't sound like all the "stray" elements are relevant.
54 <track src="captions-webvtt/metadata.vtt" onload="metadataTrackLoade d()">

OLD	NEW