Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2074813002: Roll Polymer (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Polymer See components_summary.txt for versioning details R=michaelpg@chromium.org BUG=619797 NOPRESUBMIT=true # crisper.js NOTRY=true # see patchset 2's try jobs CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/134cd0d0669376815daebd5a170184ffef3b8ebd Cr-Commit-Position: refs/heads/master@{#400318}

Patch Set 1 #

Patch Set 2 : apply https://github.com/PolymerElements/iron-collapse/pull/56 manually #

Total comments: 3

Patch Set 3 : chromium.patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+896 lines, -748 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 12 chunks +46 lines, -36 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/chromium.patch View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-box/app-box-extracted.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout.html View 2 chunks +22 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-drawer-layout/app-drawer-layout-extracted.js View 4 chunks +17 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header.html View 7 chunks +1 line, -19 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-header/app-header-extracted.js View 5 chunks +38 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-layout.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/app-scroll-effects-behavior-extracted.js View 3 chunks +13 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/blend-background-extracted.js View 1 chunk +16 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/fade-background-extracted.js View 1 chunk +23 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/parallax-background-extracted.js View 1 chunk +17 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-snapped-title-extracted.js View 3 chunks +9 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/app-scroll-effects/effects/resize-title-extracted.js View 4 chunks +9 lines, -14 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/bower.json View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-route/app-location.html View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-route/app-route.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-route/app-route-extracted.js View 2 chunks +24 lines, -15 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/app-route/bower.json View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/bower.json View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse.html View 2 chunks +15 lines, -17 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js View 1 8 chunks +35 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 8 chunks +33 lines, -31 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-location/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-location/iron-location-extracted.js View 7 chunks +20 lines, -18 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop.html View 1 chunk +21 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/bower.json View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light.html View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html View 2 chunks +7 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner.html View 1 chunk +9 lines, -29 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-lite.html View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-styles.html View 4 chunks +151 lines, -155 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tabs.html View 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tabs-extracted.js View 6 chunks +19 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/bower.json View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 42 chunks +97 lines, -96 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-micro-extracted.js View 16 chunks +48 lines, -36 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-mini-extracted.js View 19 chunks +21 lines, -37 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 13 chunks +61 lines, -68 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Dan Beam
4 years, 6 months ago (2016-06-16 18:57:11 UTC) #2
michaelpg
lgtm
4 years, 6 months ago (2016-06-16 19:35:22 UTC) #3
Dan Beam
https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js File third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js (right): https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js#newcode99 third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js:99: * @param {string} size The new value for `maxWidth`/`maxHeight` ...
4 years, 6 months ago (2016-06-16 23:01:54 UTC) #4
michaelpg
https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js File third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js (right): https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js#newcode99 third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js:99: * @param {string} size The new value for `maxWidth`/`maxHeight` ...
4 years, 6 months ago (2016-06-16 23:03:25 UTC) #5
Dan Beam
https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js File third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js (right): https://codereview.chromium.org/2074813002/diff/20001/third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js#newcode99 third_party/polymer/v1_0/components-chromium/iron-collapse/iron-collapse-extracted.js:99: * @param {string} size The new value for `maxWidth`/`maxHeight` ...
4 years, 6 months ago (2016-06-17 00:42:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074813002/40001
4 years, 6 months ago (2016-06-17 00:43:04 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-17 00:44:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:46:10 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/134cd0d0669376815daebd5a170184ffef3b8ebd
Cr-Commit-Position: refs/heads/master@{#400318}

Powered by Google App Engine
This is Rietveld 408576698