Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js

Issue 2074813002: Roll Polymer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: chromium.patch Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js b/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js
index bb84915d57ae5ab5befa0aaaf8fc006574e8de79..031f7c0c10f92adbc3747516b3e814e706e992ce 100644
--- a/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/app-layout/helpers/helpers-extracted.js
@@ -8,7 +8,7 @@ Polymer.AppLayout = Polymer.AppLayout || {};
};
/**
- * Registers a scroll effect to be used in elements that implement the
+ * Registers a scroll effect to be used in elements that implement the
* `Polymer.AppScrollEffectsBehavior` behavior.
*
* @param {string} effectName The effect name.
@@ -72,19 +72,20 @@ Polymer.AppLayout = Polymer.AppLayout || {};
var deltaScrollTop = scrollTop - currentScrollTop;
var deltaScrollLeft = scrollLeft - currentScrollLeft;
var duration = 300;
-
- (function updateFrame() {
+ var updateFrame = (function updateFrame() {
var now = Date.now();
var elapsedTime = now - startTime;
if (elapsedTime < duration) {
- scrollTo(
- timingFn(elapsedTime, currentScrollLeft, deltaScrollLeft, duration),
- timingFn(elapsedTime, currentScrollTop, deltaScrollTop, duration)
- );
- requestAnimationFrame(updateFrame.bind(this));
+ scrollTo(timingFn(elapsedTime, currentScrollLeft, deltaScrollLeft, duration),
+ timingFn(elapsedTime, currentScrollTop, deltaScrollTop, duration));
+ requestAnimationFrame(updateFrame);
+ } else {
+ scrollTo(scrollLeft, scrollTop);
}
- }).call(this);
+ }).bind(this);
+
+ updateFrame();
}
} else if (options.behavior === 'silent') {

Powered by Google App Engine
This is Rietveld 408576698