Make a copy of PageClassification enum outside the metrics code

Make a copy of PageClassification enum outside the metrics code

This will reduce in the future the number of metrics protocol buffers 
that we need to #include in various omnibox code files.  It also 
introduces better boundaries between disparate sections of the codebase.

NOTRY=true
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214132

[Mark P, 2013-07-26 15:29:57]

A simple copy as discussed.

--mark

[Peter Kasting, 2013-07-26 18:06:38]

LGTM

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
File chrome/browser/autocomplete/autocomplete_input.h (right):

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:52: INVALID_SPEC = 0,   //
invalid URI; shouldn't happen
Nit: I think you mean URL.  (Generally we don't work with URIs that aren't
URLs...)

Also, I suggest putting all the comments for each value above the value, rather
than some beside and some below.  Then I'd probably put a blank line between
each (comment + code) block and the next.

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:61: INSTANT_NEW_TAB_PAGE = 5, 
// new tab page rendered by Instant
Nit: Might want to note the instant exception on NEW_TAB_PAGE above.

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:67: // see note at the top of
this enum.
Nit: Don't duplicate this comment from above.

[Mark P, 2013-07-26 18:45:39]

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
File chrome/browser/autocomplete/autocomplete_input.h (right):

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:52: INVALID_SPEC = 0,   //
invalid URI; shouldn't happen
On 2013/07/26 18:06:38, Peter Kasting wrote:
> Nit: I think you mean URL.  (Generally we don't work with URIs that aren't
> URLs...)
> 
> Also, I suggest putting all the comments for each value above the value,
rather
> than some beside and some below.  Then I'd probably put a blank line between
> each (comment + code) block and the next.

I'd rather do this cleanup in a separate changelist so it's more obvious to see
what we change.

Furthermore, because I have to do these suggestions in three places (here,
OmniboxEventProto in chromium source tree, OmniboxEventProto in google source
tree), it makes sense to try to separate that out from this refactoring.

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:61: INSTANT_NEW_TAB_PAGE = 5, 
// new tab page rendered by Instant
On 2013/07/26 18:06:38, Peter Kasting wrote:
> Nit: Might want to note the instant exception on NEW_TAB_PAGE above.

ditto.

https://codereview.chromium.org/20747002/diff/1/chrome/browser/autocomplete/a...
chrome/browser/autocomplete/autocomplete_input.h:67: // see note at the top of
this enum.
On 2013/07/26 18:06:38, Peter Kasting wrote:
> Nit: Don't duplicate this comment from above.

Removed.

[Ilya Sherman, 2013-07-26 21:40:55]

LGTM % nit.  Thanks :)

https://codereview.chromium.org/20747002/diff/5001/chrome/browser/metrics/met...
File chrome/browser/metrics/metrics_log.cc (right):

https://codereview.chromium.org/20747002/diff/5001/chrome/browser/metrics/met...
chrome/browser/metrics/metrics_log.cc:162: default:
nit: Please remove the default case, so that it's a compile-time error to forget
to update this.  (You'll still need to have the return stmt, just outside the
switch stmt, to satisfy less wise compilers.)

[Mark P, 2013-07-26 21:55:26]

Created https://code.google.com/p/chromium/issues/detail?id=264938 to track
Peter's follow-up request.

Submitting this changelist now.

--mark

https://codereview.chromium.org/20747002/diff/5001/chrome/browser/metrics/met...
File chrome/browser/metrics/metrics_log.cc (right):

https://codereview.chromium.org/20747002/diff/5001/chrome/browser/metrics/met...
chrome/browser/metrics/metrics_log.cc:162: default:
On 2013/07/26 21:40:56, Ilya Sherman wrote:
> nit: Please remove the default case, so that it's a compile-time error to
forget
> to update this.  (You'll still need to have the return stmt, just outside the
> switch stmt, to satisfy less wise compilers.)

Done.

[commit-bot: I haz the power, 2013-07-26 23:08:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/20747002/10001

[commit-bot: I haz the power, 2013-07-28 00:42:59]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-07-28 03:51:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/20747002/10001

[commit-bot: I haz the power, 2013-07-28 05:22:23]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-07-28 15:50:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/20747002/10001

[commit-bot: I haz the power, 2013-07-28 17:41:31]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-07-28 17:42:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/20747002/10001

[commit-bot: I haz the power, 2013-07-28 18:35:54]

Change committed as 214132