Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 20747002: Make a copy of PageClassification enum outside the metrics code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ilya's comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index bdc292c8f8a68c89f27e61b0512d755ff3eca873..e4c1109e41129a6f53aad96e1146e123c60fb608 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -1254,27 +1254,25 @@ bool OmniboxEditModel::IsSpaceCharForAcceptingKeyword(wchar_t c) {
}
}
-metrics::OmniboxEventProto::PageClassification
- OmniboxEditModel::ClassifyPage() const {
+AutocompleteInput::PageClassification OmniboxEditModel::ClassifyPage() const {
if (!delegate_->CurrentPageExists())
- return metrics::OmniboxEventProto::OTHER;
+ return AutocompleteInput::OTHER;
if (delegate_->IsInstantNTP())
- return metrics::OmniboxEventProto::INSTANT_NEW_TAB_PAGE;
+ return AutocompleteInput::INSTANT_NEW_TAB_PAGE;
const GURL& gurl = delegate_->GetURL();
if (!gurl.is_valid())
- return metrics::OmniboxEventProto::INVALID_SPEC;
+ return AutocompleteInput::INVALID_SPEC;
const std::string& url = gurl.spec();
if (url == chrome::kChromeUINewTabURL)
- return metrics::OmniboxEventProto::NEW_TAB_PAGE;
+ return AutocompleteInput::NEW_TAB_PAGE;
if (url == content::kAboutBlankURL)
- return metrics::OmniboxEventProto::BLANK;
+ return AutocompleteInput::BLANK;
if (url == profile()->GetPrefs()->GetString(prefs::kHomePage))
- return metrics::OmniboxEventProto::HOMEPAGE;
+ return AutocompleteInput::HOMEPAGE;
if (view_->toolbar_model()->WouldReplaceSearchURLWithSearchTerms(true)) {
- return metrics::
- OmniboxEventProto::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
+ return AutocompleteInput::SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT;
}
- return metrics::OmniboxEventProto::OTHER;
+ return AutocompleteInput::OTHER;
}
void OmniboxEditModel::ClassifyStringForPasteAndGo(
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698