Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207443002: [GCM] Move registration info persistence from extension state store to GCM store (Closed)

Created:
6 years, 9 months ago by jianli
Modified:
6 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

[GCM] Move registration info persistence from extension state store to GCM store This is the effort decouple the extension specific logic from GCMProfileService. Also remove the code to persist user serial number mappings since it is not needed any more. BUG=343268 TEST=tests updated Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258706

Patch Set 1 : Patch #

Patch Set 2 : Fix tests #

Total comments: 2

Patch Set 3 : Fix histogram #

Patch Set 4 : Sync #

Total comments: 2

Patch Set 5 : Patch to land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+539 lines, -857 lines) Patch
M chrome/browser/services/gcm/gcm_profile_service.h View 4 chunks +1 line, -31 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 3 20 chunks +27 lines, -342 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 2 3 8 chunks +3 lines, -147 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.h View 1 2 3 4 5 chunks +9 lines, -19 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 2 3 4 2 chunks +7 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 2 3 4 12 chunks +122 lines, -186 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 2 3 4 3 chunks +52 lines, -66 lines 0 comments Download
A google_apis/gcm/engine/registration_info.h View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A google_apis/gcm/engine/registration_info.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 3 chunks +17 lines, -8 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 2 3 4 8 chunks +78 lines, -20 lines 0 comments Download
M google_apis/gcm/gcm_client_impl_unittest.cc View 1 2 3 4 11 chunks +114 lines, -18 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jianli
asvitkine for histogram. zea for everything.
6 years, 9 months ago (2014-03-21 00:26:01 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/207443002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/207443002/diff/60001/tools/metrics/histograms/histograms.xml#oldcode6603 tools/metrics/histograms/histograms.xml:6603: -<histogram name="GCM.NumUsers"> Please don't remove existing histograms. Instead, mark ...
6 years, 9 months ago (2014-03-21 15:41:36 UTC) #2
jianli
https://codereview.chromium.org/207443002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/207443002/diff/60001/tools/metrics/histograms/histograms.xml#oldcode6603 tools/metrics/histograms/histograms.xml:6603: -<histogram name="GCM.NumUsers"> On 2014/03/21 15:41:37, Alexei Svitkine wrote: > ...
6 years, 9 months ago (2014-03-21 16:54:31 UTC) #3
Alexei Svitkine (slow)
histograms lgtm
6 years, 9 months ago (2014-03-21 16:57:39 UTC) #4
Nicolas Zea
LGTM with a comment https://codereview.chromium.org/207443002/diff/100001/google_apis/gcm/engine/registration_info.h File google_apis/gcm/engine/registration_info.h (right): https://codereview.chromium.org/207443002/diff/100001/google_apis/gcm/engine/registration_info.h#newcode29 google_apis/gcm/engine/registration_info.h:29: typedef std::map<std::string, RegistrationInfo> RegistrationInfoMap; Not ...
6 years, 9 months ago (2014-03-21 19:52:40 UTC) #5
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 9 months ago (2014-03-21 20:38:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/207443002/120001
6 years, 9 months ago (2014-03-21 20:39:13 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 22:54:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 258706

Powered by Google App Engine
This is Rietveld 408576698