[GCM] Move registration info persistence from extension state store to GCM store

chrome/browser/services/gcm/gcm_profile_service_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 377 matching lines @@
                    base::Unretained(this)));
   }
 
   void RegisterCompleted(const std::string& registration_id,
                          GCMClient::Result result) {
     registration_id_ = registration_id;
     registration_result_ = result;
     waiter_->SignalCompleted();
   }
 
-  bool HasPersistedRegistrationInfo(const std::string& app_id) {
-    StateStore* storage = ExtensionSystem::Get(profile())->state_store();
-    if (!storage)
-      return false;
-    has_persisted_registration_info_ = false;
-    storage->GetExtensionValue(
-        app_id,
-        GCMProfileService::GetPersistentRegisterKeyForTesting(),
-        base::Bind(
-            &GCMProfileServiceTestConsumer::ReadRegistrationInfoFinished,
-            base::Unretained(this)));
-    waiter_->WaitUntilCompleted();
-    return has_persisted_registration_info_;
-  }
-
-  void ReadRegistrationInfoFinished(scoped_ptr<base::Value> value) {
-    has_persisted_registration_info_ = value.get() != NULL;
-    waiter_->SignalCompleted();
-  }
-
   void Send(const std::string& app_id,
             const std::string& receiver_id,
             const GCMClient::OutgoingMessage& message) {
     GetGCMProfileService()->Send(
         app_id,
         receiver_id,
         message,
         base::Bind(&GCMProfileServiceTestConsumer::SendCompleted,
                    base::Unretained(this)));
   }
@@ skipping 26 matching lines @@
   }
 
   const std::string& GetUsername() const {
     return GetGCMProfileService()->username_;
   }
 
   bool IsGCMClientReady() const {
     return GetGCMProfileService()->gcm_client_ready_;
   }
 
-  bool ExistsCachedRegistrationInfo() const {
-    return !GetGCMProfileService()->registration_info_map_.empty();
-  }
-
   bool HasAppHandlers() const {
     return !GetGCMProfileService()->app_handlers_.empty();
   }
 
   Profile* profile() const { return profile_.get(); }
   FakeGCMAppHandler* gcm_app_handler() const {
     return gcm_app_handler_.get();
   }
 
   void set_gcm_client_loading_delay(GCMClientMock::LoadingDelay delay) {
@@ skipping 387 matching lines @@
 
   WaitUntilCompleted();
   EXPECT_EQ(expected_registration_id, consumer()->registration_id());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 
   // Clears the results the would be set by the Register callback in preparation
   // to call register 2nd time.
   consumer()->clear_registration_result();
 
   // Calling register 2nd time with the same set of sender IDs but different
-  // ordering will get back the same registration ID. There is no need to wait
-  // since register simply returns the cached registration ID.
+  // ordering will get back the same registration ID.
   std::vector<std::string> another_sender_ids;
   another_sender_ids.push_back("sender2");
   another_sender_ids.push_back("sender1");
   consumer()->Register(kTestingAppId, another_sender_ids);
+
+  WaitUntilCompleted();
   EXPECT_EQ(expected_registration_id, consumer()->registration_id());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 }
 
 TEST_F(GCMProfileServiceSingleProfileTest,
        RegisterAgainWithDifferentSenderIDs) {
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   consumer()->Register(kTestingAppId, sender_ids);
   std::string expected_registration_id =
       GCMClientMock::GetRegistrationIdFromSenderIds(sender_ids);
 
   WaitUntilCompleted();
   EXPECT_EQ(expected_registration_id, consumer()->registration_id());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 
   // Make sender IDs different.
   sender_ids.push_back("sender2");
   std::string expected_registration_id2 =
       GCMClientMock::GetRegistrationIdFromSenderIds(sender_ids);
 
   // Calling register 2nd time with the different sender IDs will get back a new
   // registration ID.
   consumer()->Register(kTestingAppId, sender_ids);
   WaitUntilCompleted();
   EXPECT_EQ(expected_registration_id2, consumer()->registration_id());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 }
 
-TEST_F(GCMProfileServiceSingleProfileTest, ReadRegistrationFromStateStore) {
-  scoped_refptr<Extension> extension(consumer()->CreateExtension());
-
-  std::vector<std::string> sender_ids;
-  sender_ids.push_back("sender1");
-  consumer()->Register(extension->id(), sender_ids);
-
-  WaitUntilCompleted();
-  EXPECT_FALSE(consumer()->registration_id().empty());
-  EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
-  std::string old_registration_id = consumer()->registration_id();
-
-  // Clears the results that would be set by the Register callback in
-  // preparation to call register 2nd time.
-  consumer()->clear_registration_result();
-
-  // Register should not reach the server. Forcing GCMClient server error should
-  // help catch this.
-  consumer()->set_gcm_client_error_simulation(GCMClientMock::FORCE_ERROR);
-
-  // Simulate start-up by recreating GCMProfileService.
-  consumer()->CreateGCMProfileServiceInstance();
-
-  // Simulate start-up by reloading extension.
-  consumer()->ReloadExtension(extension);
-
-  // This should read the registration info from the extension's state store.
-  consumer()->Register(extension->id(), sender_ids);
-  PumpIOLoop();
-  PumpUILoop();
-  EXPECT_EQ(old_registration_id, consumer()->registration_id());
-  EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
-}
-
 TEST_F(GCMProfileServiceSingleProfileTest,
        GCMClientReadyAfterReadingRegistration) {
   scoped_refptr<Extension> extension(consumer()->CreateExtension());
 
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   consumer()->Register(extension->id(), sender_ids);
 
   WaitUntilCompleted();
   EXPECT_FALSE(consumer()->registration_id().empty());
@@ skipping 18 matching lines @@
   EXPECT_TRUE(consumer()->registration_id().empty());
   EXPECT_EQ(GCMClient::UNKNOWN_ERROR, consumer()->registration_result());
 
   // Register operation will be invoked after GCMClient becomes ready.
   consumer()->GetGCMClient()->PerformDelayedLoading();
   WaitUntilCompleted();
   EXPECT_EQ(old_registration_id, consumer()->registration_id());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 }
 
-TEST_F(GCMProfileServiceSingleProfileTest,
-       PersistedRegistrationInfoRemoveAfterSignOut) {
-  std::vector<std::string> sender_ids;
-  sender_ids.push_back("sender1");
-  consumer()->Register(kTestingAppId, sender_ids);
-  WaitUntilCompleted();
-
-  // The app id and registration info should be persisted.
-  EXPECT_TRUE(profile()->GetPrefs()->HasPrefPath(prefs::kGCMRegisteredAppIDs));
-  EXPECT_TRUE(consumer()->HasPersistedRegistrationInfo(kTestingAppId));
-
-  consumer()->SignOut();
-  PumpUILoop();
-
-  // The app id and persisted registration info should be removed.
-  EXPECT_FALSE(profile()->GetPrefs()->HasPrefPath(prefs::kGCMRegisteredAppIDs));
-  EXPECT_FALSE(consumer()->HasPersistedRegistrationInfo(kTestingAppId));
-}
-
 TEST_F(GCMProfileServiceSingleProfileTest, RegisterAfterSignOut) {
   // This will trigger check-out.
   consumer()->SignOut();
 
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   consumer()->Register(kTestingAppId, sender_ids);
 
   EXPECT_TRUE(consumer()->registration_id().empty());
   EXPECT_EQ(GCMClient::NOT_SIGNED_IN, consumer()->registration_result());
 }
 
 TEST_F(GCMProfileServiceSingleProfileTest, UnregisterImplicitly) {
   scoped_refptr<Extension> extension(consumer()->CreateExtension());
 
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   consumer()->Register(extension->id(), sender_ids);
 
   WaitUntilCompleted();
   EXPECT_FALSE(consumer()->registration_id().empty());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 
-  // The registration info should be cached.
-  EXPECT_TRUE(consumer()->ExistsCachedRegistrationInfo());
-
-  // The registration info should be persisted.
-  EXPECT_TRUE(consumer()->HasPersistedRegistrationInfo(extension->id()));
-
   // Uninstall the extension.
   consumer()->UninstallExtension(extension);
   base::MessageLoop::current()->RunUntilIdle();
-
-  // The cached registration info should be removed.
-  EXPECT_FALSE(consumer()->ExistsCachedRegistrationInfo());
-
-  // The persisted registration info should be removed.
-  EXPECT_FALSE(consumer()->HasPersistedRegistrationInfo(extension->id()));
 }
 
 TEST_F(GCMProfileServiceSingleProfileTest, UnregisterExplicitly) {
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   consumer()->Register(kTestingAppId, sender_ids);
 
   WaitUntilCompleted();
   EXPECT_FALSE(consumer()->registration_id().empty());
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->registration_result());
 
-  // The registration info should be cached.
-  EXPECT_TRUE(consumer()->ExistsCachedRegistrationInfo());
-
-  // The registration info should be persisted.
-  EXPECT_TRUE(consumer()->HasPersistedRegistrationInfo(kTestingAppId));
-
   consumer()->Unregister(kTestingAppId);
 
   WaitUntilCompleted();
   EXPECT_EQ(GCMClient::SUCCESS, consumer()->unregistration_result());
-
-  // The cached registration info should be removed.
-  EXPECT_FALSE(consumer()->ExistsCachedRegistrationInfo());
-
-  // The persisted registration info should be removed.
-  EXPECT_FALSE(consumer()->HasPersistedRegistrationInfo(kTestingAppId));
 }
 
 TEST_F(GCMProfileServiceSingleProfileTest,
        UnregisterWhenAsyncOperationPending) {
   std::vector<std::string> sender_ids;
   sender_ids.push_back("sender1");
   // First start registration without waiting for it to complete.
   consumer()->Register(kTestingAppId, sender_ids);
 
   // Test that unregistration fails with async operation pending when there is a
@@ skipping 123 matching lines @@
   WaitUntilCompleted();
   EXPECT_EQ(FakeGCMAppHandler::MESSAGE_EVENT,
             consumer()->gcm_app_handler()->received_event());
   EXPECT_EQ(kTestingAppId, consumer()->gcm_app_handler()->app_id());
   EXPECT_TRUE(message.data == consumer()->gcm_app_handler()->message().data);
   EXPECT_TRUE(consumer()->gcm_app_handler()->message().collapse_key.empty());
   EXPECT_EQ(message.sender_id,
             consumer()->gcm_app_handler()->message().sender_id);
 }
 
-// Flaky on all platforms: http://crbug.com/354803
-TEST_F(GCMProfileServiceSingleProfileTest,
-       DISABLED_MessageNotReceivedFromNotRegisteredSender) {
-  // Explicitly not registering the sender2 here, so that message gets dropped.
-  consumer()->Register(kTestingAppId, ToSenderList("sender1"));
-  WaitUntilCompleted();
-  GCMClient::IncomingMessage message;
-  message.data["key1"] = "value1";
-  message.data["key2"] = "value2";
-  message.sender_id = "sender2";
-  consumer()->GetGCMClient()->ReceiveMessage(kTestingAppId, message);
-  PumpUILoop();
-  EXPECT_EQ(FakeGCMAppHandler::NO_EVENT,
-            consumer()->gcm_app_handler()->received_event());
-  consumer()->gcm_app_handler()->clear_results();
-
-  // Register for sender2 and try to receive the message again, which should
-  // work with no problems.
-  consumer()->Register(kTestingAppId, ToSenderList("sender1,sender2"));
-  WaitUntilCompleted();
-  consumer()->GetGCMClient()->ReceiveMessage(kTestingAppId, message);
-  WaitUntilCompleted();
-  EXPECT_EQ(FakeGCMAppHandler::MESSAGE_EVENT,
-            consumer()->gcm_app_handler()->received_event());
-  consumer()->gcm_app_handler()->clear_results();
-
-  // Making sure that sender1 can receive the message as well.
-  message.sender_id = "sender1";
-  consumer()->GetGCMClient()->ReceiveMessage(kTestingAppId, message);
-  WaitUntilCompleted();
-  EXPECT_EQ(FakeGCMAppHandler::MESSAGE_EVENT,
-            consumer()->gcm_app_handler()->received_event());
-  consumer()->gcm_app_handler()->clear_results();
-
-  // Register for sender1 only and make sure it is not possible  to receive the
-  // message again from from sender1.
-  consumer()->Register(kTestingAppId, ToSenderList("sender2"));
-  WaitUntilCompleted();
-  consumer()->GetGCMClient()->ReceiveMessage(kTestingAppId, message);
-  PumpUILoop();
-  EXPECT_EQ(FakeGCMAppHandler::NO_EVENT,
-            consumer()->gcm_app_handler()->received_event());
-}
-
 TEST_F(GCMProfileServiceSingleProfileTest, MessageWithCollapseKeyReceived) {
   consumer()->Register(kTestingAppId, ToSenderList("sender"));
   WaitUntilCompleted();
   GCMClient::IncomingMessage message;
   message.data["key1"] = "value1";
   message.collapse_key = "collapse_key_value";
   message.sender_id = "sender";
   consumer()->GetGCMClient()->ReceiveMessage(kTestingAppId, message);
   WaitUntilCompleted();
   EXPECT_EQ(FakeGCMAppHandler::MESSAGE_EVENT,
@@ skipping 356 matching lines @@
   consumer()->gcm_app_handler()->clear_results();
   WaitUntilCompleted();
 
   EXPECT_EQ(FakeGCMAppHandler::MESSAGE_EVENT,
             consumer()->gcm_app_handler()->received_event());
   EXPECT_TRUE(
       in_message5.data == consumer()->gcm_app_handler()->message().data);
 }
 
 }  // namespace gcm