Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2074373003: No ScopedVector in PasswordFormManager::not_best_matches_ (Closed)

Created:
4 years, 6 months ago by vabr (Chromium)
Modified:
4 years, 6 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No ScopedVector in PasswordFormManager::not_best_matches_ PasswordFormManager::not_best_matches_ used to be a ScopedVector, now it is a vector of unique_ptr. BUG=555132 Committed: https://crrev.com/dc03302ee02bf4057342f98a026a9d745cfd9fe3 Cr-Commit-Position: refs/heads/master@{#400694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
vabr (Chromium)
Hi Vasilii, Please take a look at this surprisingly easy conversion. :) Cheers, Vaclav
4 years, 6 months ago (2016-06-20 15:25:28 UTC) #2
vasilii
lgtm
4 years, 6 months ago (2016-06-20 15:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074373003/1
4 years, 6 months ago (2016-06-20 15:57:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 16:15:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 16:17:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc03302ee02bf4057342f98a026a9d745cfd9fe3
Cr-Commit-Position: refs/heads/master@{#400694}

Powered by Google App Engine
This is Rietveld 408576698