Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2074333002:
Flip FYI Win Goma builders to GN. (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip FYI Win Goma builders to GN.
Now that nearly all of the Win builders are on GN, the
Goma builders should be, too.
TBR=ukai@chromium.org, thakis@chromium.org
BUG=605318
Committed: https://crrev.com/a256069d5d0c34e4da9d21e91acad17c5c907e20
Cr-Commit-Position: refs/heads/master@{#401202}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 20 (8 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm, this is really up to goma team, and ukai already lg'd.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074333002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074333002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Flip FYI Win Goma builders to GN. Now that nearly all of the Win builders are on GN, the Goma builders should be, too. TBR=ukai@chromium.org, thakis@chromium.org BUG=605318 ========== to ========== Flip FYI Win Goma builders to GN. Now that nearly all of the Win builders are on GN, the Goma builders should be, too. TBR=ukai@chromium.org, thakis@chromium.org BUG=605318 Committed: https://crrev.com/a256069d5d0c34e4da9d21e91acad17c5c907e20 Cr-Commit-Position: refs/heads/master@{#401202} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a256069d5d0c34e4da9d21e91acad17c5c907e20 Cr-Commit-Position: refs/heads/master@{#401202} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
