Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/compiler/instruction.h

Issue 2074323002: [Turbofan] Merge SpillRanges by byte_width rather than kind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph-visualizer.cc ('k') | src/compiler/register-allocator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index 7130c3d53f3b9ea07a97aa9bf811506465037622..76bc09b6164ab835c527991117642281a2cb2d9b 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -605,16 +605,15 @@ bool InstructionOperand::IsSimd128StackSlot() const {
uint64_t InstructionOperand::GetCanonicalizedValue() const {
if (IsAllocated() || IsExplicit()) {
- MachineRepresentation rep = LocationOperand::cast(this)->representation();
MachineRepresentation canonical = MachineRepresentation::kNone;
- if (IsFloatingPoint(rep)) {
+ if (IsFPRegister()) {
if (kSimpleFPAliasing) {
- // Archs with simple aliasing can treat all FP operands the same.
+ // We treat all FP register operands the same for simple aliasing.
canonical = MachineRepresentation::kFloat64;
} else {
- // We need to distinguish FP operands of different reps when FP
+ // We need to distinguish FP register operands of different reps when
// aliasing is not simple (e.g. ARM).
- canonical = rep;
+ canonical = LocationOperand::cast(this)->representation();
}
}
return InstructionOperand::KindField::update(
« no previous file with comments | « src/compiler/graph-visualizer.cc ('k') | src/compiler/register-allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698