remoting/remoting_host_win.gypi - Issue 2073943002: [Chromoting] Disable building 64bit chromoting.msi file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/remoting_host_win.gypi

Issue 2073943002: [Chromoting] Disable building 64bit chromoting.msi file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/remoting_host_win.gypi

diff --git a/remoting/remoting_host_win.gypi b/remoting/remoting_host_win.gypi

index f998e05ba595b00454a6e5db8a398d2c6308c402..feb2c1333e0625d82dc53719cb796cb560c268cb 100644

--- a/remoting/remoting_host_win.gypi

+++ b/remoting/remoting_host_win.gypi

@@ -563,7 +563,7 @@

# component build is used the produced installation will not work due to

# missing DLLs. We build it anyway to make sure the GYP scripts are executed

# by the bots.

- ['wix_exists == "True"', {

+ ['wix_exists == "True" and target_arch == "ia32"', {

joedow 2016/06/20 22:15:04 nit: Add comment on why we don't build for x64.

Hzj_jie 2016/06/21 02:14:55 Done.

'targets': [

{

'target_name': 'remoting_host_installation',

« remoting/host/BUILD.gn ('K') | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »