Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207383002: Remove repaint.js from layout tests (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Remove repaint.js from layout tests All of these tests don't seem to depend on minimizing repaints and are more trying to make sure that something has repainted. Therefore, change them all to just use rAF rather than repaint.js and make them pixel tests where applicable. BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170237

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : More expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -80 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-scroll.html View 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/compositing/repaint/newly-composited-on-scroll.html View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/newly-composited-repaint-rect.html View 2 chunks +11 lines, -10 lines 0 comments Download
M LayoutTests/compositing/repaint/shrink-layer.html View 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-as-image-incremental-repaint.html View 2 chunks +8 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-composite-fill-repaint.html View 2 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-incremental-repaint.html View 6 chunks +15 lines, -11 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-incremental-repaint-2.html View 2 chunks +6 lines, -4 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-resize-after-paint-without-layout.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/drawImage-with-broken-image.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/setWidthResetAfterForcedRender.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html View 2 chunks +7 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/4774354.html View 3 chunks +2 lines, -4 lines 0 comments Download
M LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/repaint/background-blend-mode-image-color-dynamic-expected.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/repaint/percent-minheight-resize.html View 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/percent-minheight-resize-expected.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table.html View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html View 2 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/sub-pixel/transformed-iframe-copy-on-scroll.html View 2 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/table/simple_paint.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
enne (OOO)
6 years, 9 months ago (2014-03-20 23:59:17 UTC) #1
enne (OOO)
+ojan
6 years, 9 months ago (2014-03-27 19:29:49 UTC) #2
ojan
lgtm
6 years, 9 months ago (2014-03-27 22:02:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/1
6 years, 9 months ago (2014-03-27 22:02:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:34:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-27 22:34:22 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 22:46:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/40001
6 years, 9 months ago (2014-03-27 22:46:27 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:49:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 22:49:43 UTC) #10
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 22:50:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/40001
6 years, 9 months ago (2014-03-27 22:50:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:53:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 22:53:51 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 22:57:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/40001
6 years, 9 months ago (2014-03-27 22:57:26 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:28:50 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 23:28:50 UTC) #18
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 23:37:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/40001
6 years, 9 months ago (2014-03-27 23:37:30 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:50:48 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 23:50:49 UTC) #22
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-28 00:06:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207383002/40001
6 years, 9 months ago (2014-03-28 00:06:27 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 01:12:36 UTC) #25
Message was sent while issue was closed. 
Change committed as 170237

Powered by Google App Engine
This is Rietveld 408576698