third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp - Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Integrate feedback. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | third_party/WebKit/Source/core/layout/README.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

index a95a49a71e3c7f9e27b2f32555e037cdbed665fd..a27ce472645453c5f4b71b62f55da6e1cffa4d20 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

@@ -102,9 +102,7 @@ bool LayoutFlowThread::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject

// |rect| is a layout rectangle, where the block direction coordinate is flipped for writing

// mode. fragmentsBoundingBox(), on the other hand, works on physical rectangles, so we need to

// flip the rectangle before and after calling it.

- flipForWritingMode(rect);

rect = fragmentsBoundingBox(rect);

- flipForWritingMode(rect);

return LayoutBlockFlow::mapToVisualRectInAncestorSpace(ancestor, rect, visualRectFlags);

}