third_party/WebKit/Source/core/layout/README.md - Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/README.md

Issue 2073563002: Rework mapToVisualRectInAncestorSpace to handle flipped blocks correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Integrate feedback. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('j') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/README.md

diff --git a/third_party/WebKit/Source/core/layout/README.md b/third_party/WebKit/Source/core/layout/README.md

index 61cbadac9c369c2a830c8a4b3592c357e91f2fa2..2d21ddf808f5a7dff10941b7b19dd869a21c8309 100644

--- a/third_party/WebKit/Source/core/layout/README.md

+++ b/third_party/WebKit/Source/core/layout/README.md

@@ -28,7 +28,7 @@ direction:rtl | | box |

| | |

|__________|__________|

chrishtr 2016/07/11 22:35:11 Spurious edits in this file.

wkorman 2016/07/11 22:46:17 Done.

overflow rect

|<--------------------->|

@@ -55,9 +55,9 @@ direction:rtl | |/| box |

overflow rect

|<--------------------->|

content

rect

|<-------->|

@@ -74,6 +74,10 @@ writing-mode: | | |/|

| | |/|

|__________|__________|/|

overflow rect

|<--------------------->|

+## Coordinate Spaces

+TODO(wkorman): Document writing mode, particularly flipped blocks.